Skip to content

Reland "Fail tests on exceptions raised after test completed (#144706)" #144980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 12, 2024
Merged

Reland "Fail tests on exceptions raised after test completed (#144706)" #144980

auto-submit merged 1 commit into from
Mar 12, 2024

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 12, 2024 •
edited
Loading

Reverts #144970

No changes in this PR compared to the original. The test failure was fixed by adding missing awaits in #144978.

Fixes #144353.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 12, 2024
@goderbauer goderbauer requested a review from gspencergoog March 12, 2024 16:52
gspencergoog
gspencergoog approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2024
@auto-submit auto-submit bot merged commit 77651bc into master Mar 12, 2024
@auto-submit auto-submit bot deleted the revert-144970-revert_91cccc8e6b83ada2dcffe266ff4a6d3c8d0ea582 branch March 12, 2024 18:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
bfdc172 
…(#144706)" (flutter/flutter#144980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
144ba61 
…(#144706)" (flutter/flutter#144980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
ecdc4c5 
…(#144706)" (flutter/flutter#144980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
0bad339 
…(#144706)" (flutter/flutter#144980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
63a0f72 
…(#144706)" (flutter/flutter#144980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
1b7e50b 
…(#144706)" (flutter/flutter#144980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
117b290 
…(#144706)" (flutter/flutter#144980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
291fb3d 
…(#144706)" (flutter/flutter#144980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
0eff0c7 
…(#144706)" (flutter/flutter#144980)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
4391964 
…(#144706)" (flutter/flutter#144980)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
b9e50b2 
…(#144706)" (flutter/flutter#144980)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
3279fb1 
…(#144706)" (flutter/flutter#144980)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
454aa5b 
…(#144706)" (flutter/flutter#144980)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
435f2dd 
…(#144706)" (flutter/flutter#144980)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
a79b6a5 
…(#144706)" (flutter/flutter#144980)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
d7174a4 
…(#144706)" (flutter/flutter#144980)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
da5eda9 
…(#144706)" (flutter/flutter#144980)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
77651bc Reland "Fail tests on exceptions raised after test completed …
8dc1eb7 
…(#144706)" (flutter/flutter#144980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API example smoke test failing silently

2 participants

@goderbauer @gspencergoog