Fix Cupertino Context Menu #144883
Fix Cupertino Context Menu #144883
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
a: text input
drxddy
changed the title
drxddy
force-pushed
the
patch-1
branch
2 times, most recently
from
661dd08 to
e3ab5eb
Compare
…ell Transparent The existing version assumes the background is in Pure White (0xFFFFFFFF), and the Container that Shells the child in _buildAnimation should not assume any color.
justinmc
requested review from
MitchellGoodwin
and removed request for
navaronbracke
|
Thanks, I agree with you @justinmc, realized a simpler way to test this is by using So this latest commit 49ba870 simplifies and undoes a lot of workarounds done in previous commits, and reverts to the old version of the file with just removal of white color in
|
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
One question about other white colors I found in the file. Otherwise I think this looks good, but @MitchellGoodwin should have the final say as to whether that white color was there for a good reason or not.
MitchellGoodwin
left a comment
MitchellGoodwin
left a comment
There was a problem hiding this comment.
Getting rid of the white color seems to cause no issues. I think it was there from an incorrect assumption that CupertinoContext menu would be used only in a native iOS-like background.
Echoing Justin, it should probably be removed from examples in this file.
…r from doc comments in context_menu.dart
drxddy
changed the title
drxddy
changed the title
4 participants
Summary
The current implementation of
CupertinoContextMenu, on long press, while animating the child up, it's using a Container Shell in_buildAnimationwith a pure White Color (0xFFFFFFFF), instead of being Transparent, this causes white corner borders for those developers that use a higher corner radius in child Widget,Problem Detail:
When you long press on the Widget after using this
CupertinoContextMenuas a parent, it will start animating the child out to occupy half the screen in the top, while this animation happens ( before blur appears on the screen & previewBuilder is rendered), the child is used in a Container with a decoration of pure white color (0xFFFFFFFF), with no border-radius, this will cause inconsistent looks while the child undergoes a transition.This issue does not exist when using
CupertinoContextMenu.builder, this is howCupertinoContextMenushould also be working.Fixes #144886
Video
Screen.Recording.2024-03-10.at.01.47.03.mov
Pre-launch Checklist
///).