Skip to content

[framework] fix incorrect chinese localizations for Search Web and Share in selection controls #144857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LouiseHsu merged 5 commits into from
Mar 14, 2024
Merged

[framework] fix incorrect chinese localizations for Search Web and Share in selection controls #144857

LouiseHsu merged 5 commits into from
Mar 14, 2024

Conversation

@LouiseHsu
Copy link
Contributor

@LouiseHsu LouiseHsu commented Mar 8, 2024 •
edited
Loading

Fixes #144825

Corresponding translation suggestions:
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-TW
(I accidentally pressed submit 3 times :( )
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-HK
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-CN
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8883913494819754382&language=zh-CN

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository labels Mar 8, 2024
@LouiseHsu LouiseHsu changed the title init [framework] fix incorrect chinese localizations for Search Web and Share in selection controls Mar 9, 2024
@LouiseHsu LouiseHsu marked this pull request as ready for review March 11, 2024 20:18
@LouiseHsu LouiseHsu requested a review from justinmc March 11, 2024 20:19
justinmc
justinmc approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 11, 2024

auto label is removed for flutter/flutter/144857, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2024
@LouiseHsu LouiseHsu merged commit 9f5fd75 into flutter:master Mar 14, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
6a0826b 
…b and Share in selection controls (flutter/flutter#144857)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
b19d1b9 
…b and Share in selection controls (flutter/flutter#144857)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
6348aa9 
…b and Share in selection controls (flutter/flutter#144857)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
6a75a29 
…b and Share in selection controls (flutter/flutter#144857)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
745cb1b 
…b and Share in selection controls (flutter/flutter#144857)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
54229d3 
…b and Share in selection controls (flutter/flutter#144857)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
0a7df81 
…b and Share in selection controls (flutter/flutter#144857)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
32443f8 
…b and Share in selection controls (flutter/flutter#144857)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
8653b74 
…b and Share in selection controls (flutter/flutter#144857)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
621e383 
…b and Share in selection controls (flutter/flutter#144857)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
2e8315b 
…b and Share in selection controls (flutter/flutter#144857)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
4fdd9e3 
…b and Share in selection controls (flutter/flutter#144857)
@darshankawar darshankawar mentioned this pull request Mar 20, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
9f5fd75 [framework] fix incorrect chinese localizations for Search We…
702094a 
…b and Share in selection controls (flutter/flutter#144857)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect zh-CN translations on some texts

2 participants

@LouiseHsu @justinmc