Skip to content

Roll pub packages #144852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flutter-pub-roller-bot wants to merge 1 commit into from
Closed

Roll pub packages #144852

flutter-pub-roller-bot wants to merge 1 commit into from

Conversation

@flutter-pub-roller-bot
Copy link
Contributor

@flutter-pub-roller-bot flutter-pub-roller-bot commented Mar 8, 2024

This PR was generated by flutter update-packages --force-upgrade.

@flutter-pub-roller-bot flutter-pub-roller-bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 8, 2024
@flutter-pub-roller-bot flutter-pub-roller-bot added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2024
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically f: integration_test The flutter/packages/integration_test plugin labels Mar 8, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 8, 2024

auto label is removed for flutter/flutter/144852, due to - The status or check suite Linux_android hot_mode_dev_cycle_linux__benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux web_benchmarks_html has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer mentioned this pull request Mar 11, 2024
Merged
@goderbauer
Copy link
Member

goderbauer commented Mar 11, 2024

#144968 fixes the typing issue that this roll is stumbling over.

auto-submit bot pushed a commit that referenced this pull request Mar 12, 2024
@goderbauer
Fix typing to unblock pub roll (#144968)
68138bc 
The pub roller is blocked on

```
  error � The argument type 'JSArray<JSAny?>' can't be assigned to the parameter type 'JSArray<JSNumber>'.  � dev/benchmarks/macrobenchmarks/lib/web_benchmarks.dart:309:22 � argument_type_not_assignable
```

See #144852.

The fixes the typing so the next pub roll can (hopefully) succeed.
@goderbauer
Copy link
Member

goderbauer commented Mar 12, 2024

#144968 landed. I am going to close this one and have the roller open a new one.

@goderbauer goderbauer closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flutter-pub-roller-bot @goderbauer @fluttergithubbot