Remove toString() overrides in dart:ui/package:flutter in profile/release mode on wasm/vm targets
#144763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
the
tool
…le/release mode on wasm/vm targets The flutter engine & framework can opt out of this optimization for individual classes / class hierarchies via: * `@pragma(flutter:keep-to-string)` * `@pragma(flutter:keep-to-string-in-subtypes)` Or by using the convenience constant `@keepToString` from `dart:ui`. => This aligns the build process more with g3 (which already does this)
mkustermann
force-pushed
the
delete-tostring
branch
from
bb607bc to
4e9ff49
Compare
yjbanov
approved these changes
Mar 7, 2024
Member
Author
|
I'll go ahead and land it as I don't expect there to be any issues. @dnfield If you have a concern about enabling it on the VM AOT let me know - we could always revert it if needed. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2024
…in profile/release mode on wasm/vm targets (flutter/flutter#144763)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 8, 2024
flutter/flutter@471a828...7c89ec8 2024-03-08 [email protected] Remove `toString()` overrides in `dart:ui`/`package:flutter` in profile/release mode on wasm/vm targets (flutter/flutter#144763) 2024-03-08 [email protected] Roll Flutter Engine from 80cd7981043f to bbb1ed00af49 (3 revisions) (flutter/flutter#144813) 2024-03-08 [email protected] Update documentation of `AlertDialog`'s default `TextStyle` for Material 3 (flutter/flutter#144697) 2024-03-08 [email protected] Roll Flutter Engine from 175069397a40 to 80cd7981043f (5 revisions) (flutter/flutter#144804) 2024-03-07 [email protected] Enable asset transformation for `flutter run -d <browser>` and `flutter test` (flutter/flutter#144734) 2024-03-07 [email protected] Roll Flutter Engine from ec4f9af3d53b to 175069397a40 (2 revisions) (flutter/flutter#144799) 2024-03-07 [email protected] refactor: Remove `throwOnPluginPubspecError` flag for plugin validation (flutter/flutter#144214) 2024-03-07 [email protected] Roll Flutter Engine from 305333c50191 to ec4f9af3d53b (1 revision) (flutter/flutter#144797) 2024-03-07 [email protected] Roll Flutter Engine from c2863530ce39 to 305333c50191 (1 revision) (flutter/flutter#144793) 2024-03-07 [email protected] Fixed -> DropdownMenu throws exception when it is in any scrollable l� (flutter/flutter#140566) 2024-03-07 [email protected] Roll Flutter Engine from 9e8ccaa3842e to c2863530ce39 (2 revisions) (flutter/flutter#144792) 2024-03-07 [email protected] Roll Flutter Engine from 12828950890a to 9e8ccaa3842e (1 revision) (flutter/flutter#144784) 2024-03-07 [email protected] Marks Mac_x64 module_test_ios to be flaky (flutter/flutter#144681) 2024-03-07 [email protected] [flutter_tools] add custom tool analysis to analyze.dart, lint Future.catchError (flutter/flutter#140122) 2024-03-07 [email protected] Roll Flutter Engine from f8c3b2db8cd1 to 12828950890a (1 revision) (flutter/flutter#144775) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
…in profile/release mode on wasm/vm targets (flutter/flutter#144763)
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Jun 7, 2024
toString methods are removed in AOT builds by the optimization in flutter#144763 This PR disables that for Key subclasses because some applications rely on the previous behavior. Fixes flutter#148983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flutter engine & framework can opt out of this optimization for individual classes / class hierarchies via:
@pragma(flutter:keep-to-string)@pragma(flutter:keep-to-string-in-subtypes)Or by using the convenience constant
@keepToStringfromdart:ui.=> This aligns the build process more with g3 (which already does this)
Closes #52759