Add platform check to FocusManager app lifecycle listener
#144718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
gspencergoog
reviewed
Mar 7, 2024
gspencergoog
reviewed
Mar 8, 2024
Contributor
|
@nate-thegrate Could you write a quick test for this that makes sure it doesn't do anything on Android? That's all that is missing. We'd like to get this in, as it's a bit urgent for our customers (because their customers can't type in necessary information). |
Contributor
Author
|
@gspencergoog test has been added! |
gspencergoog
added
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 12, 2024
flutter/flutter@1ca8873...61812ca 2024-03-12 [email protected] Add platform check to `FocusManager` app lifecycle listener (flutter/flutter#144718) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a temporary fix for the mobile device keyboard bug reported in this comment.
CC @gspencergoog