fix popup menu offset when using useRootNavigator in PopupMenu
#144670
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
framework
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution:)
There was a problem hiding this comment.
nit: don't need to start a new line here:)
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for fixing this!
|
@joodo Could you help with the conflicts? Then we are good to go! |
QuncCccccc
force-pushed
the
fix-popup-menu-offset
branch
from
b7e8411 to
e13ad96
Compare
QuncCccccc
added
the
autosubmit
flutter/flutter@8dd0831...cb26a01 2024-05-25 [email protected] Roll Flutter Engine from e0207131ea13 to 1d154ff93a87 (1 revision) (flutter/flutter#149070) 2024-05-25 [email protected] Roll Flutter Engine from f693fdd840e8 to e0207131ea13 (7 revisions) (flutter/flutter#149068) 2024-05-25 [email protected] Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) (flutter/flutter#149057) 2024-05-24 [email protected] fix popup menu offset when using `useRootNavigator` in `PopupMenu` (flutter/flutter#144670) 2024-05-24 [email protected] [GAR][a11y] Update assessment app to unblock tester from testing dark mode (flutter/flutter#149055) 2024-05-24 [email protected] [a11y] Slider should respect bold text setting (flutter/flutter#149053) 2024-05-24 [email protected] Add tests for editable_text.on_changed.0.dart API example. (flutter/flutter#148874) 2024-05-24 [email protected] Roll Flutter Engine from 979214444aca to b5e98f9b8d0f (1 revision) (flutter/flutter#149051) 2024-05-24 [email protected] Add test for text_editing_controller.0.dart API example. (flutter/flutter#148872) 2024-05-24 [email protected] Roll Flutter Engine from 4ab442475223 to 979214444aca (3 revisions) (flutter/flutter#149045) 2024-05-24 [email protected] Fix TwoDimensionalViewport's keep alive child not always removed (when no longer should be kept alive) (flutter/flutter#148298) 2024-05-24 [email protected] Roll Packages from 1008d9e to 7b423f5 (2 revisions) (flutter/flutter#149043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
fix issue #144669
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.