Revert "_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)" #144579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
framework
Member
Author
|
cc @ksokolovskyi (original author) @polina-c (original reviewer) |
cbracken
approved these changes
Mar 5, 2024
Contributor
|
test-exempt: reverting to previous known good state |
goderbauer
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/144579, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
goderbauer
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/144579, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…oller instances. (flutter#136608)" This reverts commit 9fa9fd3.
goderbauer
added
the
autosubmit
Contributor
|
Thank you! |
Member
Author
|
The promised regression test for this is in #144627, to be submitted after this revert has landed. |
Contributor
|
@goderbauer Thank you! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2024
… TabContoller instances. (#136608)" (flutter/flutter#144579)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2024
… TabContoller instances. (#136608)" (flutter/flutter#144579)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 6, 2024
flutter/flutter@3b5a2ec...8f84f3f 2024-03-06 [email protected] Roll Packages from 2aa6e3f to 9b88dbc (8 revisions) (flutter/flutter#144693) 2024-03-06 [email protected] Roll Flutter Engine from 370e7d5866d9 to b6efe0dd88fe (1 revision) (flutter/flutter#144668) 2024-03-06 [email protected] Roll Flutter Engine from d374c78bcf52 to 370e7d5866d9 (1 revision) (flutter/flutter#144661) 2024-03-06 [email protected] Roll Flutter Engine from effcf97a1f7c to d374c78bcf52 (5 revisions) (flutter/flutter#144659) 2024-03-06 [email protected] Fill in SliverConstraints fields missing from ==, hashCode, toString (flutter/flutter#143661) 2024-03-06 [email protected] Roll Flutter Engine from 49bc1577f317 to effcf97a1f7c (10 revisions) (flutter/flutter#144653) 2024-03-05 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.0.2 to 4.1.0 (flutter/flutter#144174) 2024-03-05 [email protected] Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods (flutter/flutter#144248) 2024-03-05 [email protected] Enable asset transformation feature in hot reload workflow (excluding Web) (flutter/flutter#144161) 2024-03-05 [email protected] Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) (flutter/flutter#144639) 2024-03-05 [email protected] Updated the smiley TextButton example again (flutter/flutter#144630) 2024-03-05 [email protected] Adds missing `style` to `PopupMenuButton` (flutter/flutter#143392) 2024-03-05 [email protected] Roll Flutter Engine from a7c785884903 to 3e8b0deffe4e (1 revision) (flutter/flutter#144629) 2024-03-05 [email protected] Add regression test for TabBar crash (flutter/flutter#144627) 2024-03-05 [email protected] Roll Packages from 0625827 to 2aa6e3f (5 revisions) (flutter/flutter#144628) 2024-03-05 [email protected] remove unused `firstBuildTime` parameter in `DevFS::update` (flutter/flutter#144576) 2024-03-05 [email protected] Roll Flutter Engine from 8916bb32b7b8 to a7c785884903 (1 revision) (flutter/flutter#144624) 2024-03-05 [email protected] Revert "_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)" (flutter/flutter#144579) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/packages
that referenced
this pull request
Mar 7, 2024
flutter/flutter@3b5a2ec...8f84f3f 2024-03-06 [email protected] Roll Packages from 2aa6e3f to 9b88dbc (8 revisions) (flutter/flutter#144693) 2024-03-06 [email protected] Roll Flutter Engine from 370e7d5866d9 to b6efe0dd88fe (1 revision) (flutter/flutter#144668) 2024-03-06 [email protected] Roll Flutter Engine from d374c78bcf52 to 370e7d5866d9 (1 revision) (flutter/flutter#144661) 2024-03-06 [email protected] Roll Flutter Engine from effcf97a1f7c to d374c78bcf52 (5 revisions) (flutter/flutter#144659) 2024-03-06 [email protected] Fill in SliverConstraints fields missing from ==, hashCode, toString (flutter/flutter#143661) 2024-03-06 [email protected] Roll Flutter Engine from 49bc1577f317 to effcf97a1f7c (10 revisions) (flutter/flutter#144653) 2024-03-05 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.0.2 to 4.1.0 (flutter/flutter#144174) 2024-03-05 [email protected] Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods (flutter/flutter#144248) 2024-03-05 [email protected] Enable asset transformation feature in hot reload workflow (excluding Web) (flutter/flutter#144161) 2024-03-05 [email protected] Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) (flutter/flutter#144639) 2024-03-05 [email protected] Updated the smiley TextButton example again (flutter/flutter#144630) 2024-03-05 [email protected] Adds missing `style` to `PopupMenuButton` (flutter/flutter#143392) 2024-03-05 [email protected] Roll Flutter Engine from a7c785884903 to 3e8b0deffe4e (1 revision) (flutter/flutter#144629) 2024-03-05 [email protected] Add regression test for TabBar crash (flutter/flutter#144627) 2024-03-05 [email protected] Roll Packages from 0625827 to 2aa6e3f (5 revisions) (flutter/flutter#144628) 2024-03-05 [email protected] remove unused `firstBuildTime` parameter in `DevFS::update` (flutter/flutter#144576) 2024-03-05 [email protected] Roll Flutter Engine from 8916bb32b7b8 to a7c785884903 (1 revision) (flutter/flutter#144624) 2024-03-05 [email protected] Revert "_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)" (flutter/flutter#144579) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
… TabContoller instances. (#136608)" (flutter/flutter#144579)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9fa9fd3.
Fixes #144087.
Fixes #138588.
This crash has been reported previously from a customer in google3 in #138588, but we weren't able to track it down. Thankfully, a repro was now provided in #144087 (comment) which traced the crash down to a change made in #136608. This PR reverts that change to fix that crash for now. I will post a new PR shortly (edit: #144627) that will add a test to cover the use case that caused the crash with #136608 to make sure we don't re-introduce the crash in the future.