Skip to content

Print warning and exit when iOS device is unpaired #144551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Mar 4, 2024
Merged

Print warning and exit when iOS device is unpaired #144551

auto-submit merged 2 commits into from
Mar 4, 2024

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Mar 4, 2024

Explicitly handle the case where the iOS device is not paired. On flutter run show an error and bail instead of trying and failing to launch on the device.

On this PR:

$ flutter run -d 00008110-0009588C2651401E
'iPhone' is not paired. Open Xcode and trust this computer when prompted.
$

Fixes #144447
Closes #144095

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Mar 4, 2024
@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Mar 4, 2024
@jmagman jmagman mentioned this pull request Mar 4, 2024
Closed
jmagman
jmagman commented Mar 4, 2024
View reviewed changes
packages/flutter_tools/lib/src/macos/xcdevice.dart
isConnected = false;
}
// Error: iPhone is not paired with your computer. To use iPhone with Xcode, unlock it and choose to trust this computer when prompted. (code -9)
if (code == -9) {
Copy link
Member Author

@jmagman jmagman Mar 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: the ios-trust-failure usage event above: I can't remember if there's a case where the error message is "not paired" but the error code is not -9 (I imagine there was or we would have checked this code? Although the error parsing predates the code checking, I believe). So I left the behavior as-is.

christopherfujino
christopherfujino approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jmagman jmagman requested a review from vashworth March 4, 2024 18:44
vashworth
vashworth approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2024
@auto-submit auto-submit bot merged commit 9b442b2 into flutter:master Mar 4, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2024
@engine-flutter-autoroll
9b442b2 Print warning and exit when iOS device is unpaired (flutter/f…
175cc6f 
…lutter#144551)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2024
@engine-flutter-autoroll
9b442b2 Print warning and exit when iOS device is unpaired (flutter/f…
8399c41 
…lutter#144551)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2024
@engine-flutter-autoroll
9b442b2 Print warning and exit when iOS device is unpaired (flutter/f…
b7399c3 
…lutter#144551)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 5, 2024
@engine-flutter-autoroll
Roll Flutter from 65cd84b to 3b5a2ec (26 revisions) (#6269)
4200177 
flutter/flutter@65cd84b...3b5a2ec

2024-03-05 [email protected] Roll Flutter Engine from 17a4b66e0729 to 8916bb32b7b8 (1 revision) (flutter/flutter#144615)
2024-03-05 [email protected] Roll Flutter Engine from d514a302cdff to 17a4b66e0729 (8 revisions) (flutter/flutter#144607)
2024-03-05 [email protected] Do not shorten native assets framework names (flutter/flutter#144568)
2024-03-05 [email protected] Restorable CupertinoTextFormFieldRow (flutter/flutter#144541)
2024-03-05 [email protected] Updated the TextButton image button example artwork (flutter/flutter#144583)
2024-03-05 [email protected] Roll Flutter Engine from 728aa4ef05d4 to d514a302cdff (2 revisions) (flutter/flutter#144581)
2024-03-05 [email protected] Roll Flutter Engine from 62cf93be60b2 to 728aa4ef05d4 (3 revisions) (flutter/flutter#144578)
2024-03-05 [email protected] Disable super flakey impeller test. (flutter/flutter#144573)
2024-03-04 [email protected] Roll Flutter Engine from 40018811ec0e to 62cf93be60b2 (1 revision) (flutter/flutter#144572)
2024-03-04 [email protected] Roll Flutter Engine from 0d8588b1de7a to 40018811ec0e (6 revisions) (flutter/flutter#144570)
2024-03-04 [email protected] Print warning and exit when iOS device is unpaired (flutter/flutter#144551)
2024-03-04 [email protected] Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) (flutter/flutter#144558)
2024-03-04 [email protected] Remove unnecessary (and the only) `RenderObject.markParentNeedsLayout` override (flutter/flutter#144466)
2024-03-04 [email protected] Fix text color for default CupertinoContextMenuAction (flutter/flutter#144542)
2024-03-04 [email protected] Add missing parameter to `TableBorder.symmetric`, and improve class constructors (flutter/flutter#144279)
2024-03-04 [email protected] Fix build mode not propagated in android native asset build (flutter/flutter#144550)
2024-03-04 [email protected] Roll Packages from a9c68b8 to 0625827 (3 revisions) (flutter/flutter#144556)
2024-03-04 [email protected] Roll Flutter Engine from afd2d9f9421d to a31209171949 (1 revision) (flutter/flutter#144554)
2024-03-04 [email protected] Doc fix for `DropdownButtonFormField.value` (flutter/flutter#144427)
2024-03-04 [email protected] Fix Small Typo in Skia_Client Doc Comment (flutter/flutter#144490)
2024-03-04 [email protected] Roll Flutter Engine from 2338a557e018 to afd2d9f9421d (1 revision) (flutter/flutter#144549)
2024-03-04 [email protected] [Windows] Update keyboard modifiers link (flutter/flutter#144426)
2024-03-04 [email protected] Roll Flutter Engine from 9cbca80e2196 to 2338a557e018 (2 revisions) (flutter/flutter#144545)
2024-03-04 [email protected] Roll Flutter Engine from c52b3033eca6 to 9cbca80e2196 (1 revision) (flutter/flutter#144523)
2024-03-04 [email protected] Roll Flutter Engine from 024ea680ceed to c52b3033eca6 (1 revision) (flutter/flutter#144522)
2024-03-03 [email protected] Roll Flutter Engine from 2706c732b22a to 024ea680ceed (1 revision) (flutter/flutter#144519)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll @LouiseHsu
Roll Flutter from 65cd84b to 3b5a2ec (26 revisions) (flutter#6269)
1e98564 
flutter/flutter@65cd84b...3b5a2ec

2024-03-05 [email protected] Roll Flutter Engine from 17a4b66e0729 to 8916bb32b7b8 (1 revision) (flutter/flutter#144615)
2024-03-05 [email protected] Roll Flutter Engine from d514a302cdff to 17a4b66e0729 (8 revisions) (flutter/flutter#144607)
2024-03-05 [email protected] Do not shorten native assets framework names (flutter/flutter#144568)
2024-03-05 [email protected] Restorable CupertinoTextFormFieldRow (flutter/flutter#144541)
2024-03-05 [email protected] Updated the TextButton image button example artwork (flutter/flutter#144583)
2024-03-05 [email protected] Roll Flutter Engine from 728aa4ef05d4 to d514a302cdff (2 revisions) (flutter/flutter#144581)
2024-03-05 [email protected] Roll Flutter Engine from 62cf93be60b2 to 728aa4ef05d4 (3 revisions) (flutter/flutter#144578)
2024-03-05 [email protected] Disable super flakey impeller test. (flutter/flutter#144573)
2024-03-04 [email protected] Roll Flutter Engine from 40018811ec0e to 62cf93be60b2 (1 revision) (flutter/flutter#144572)
2024-03-04 [email protected] Roll Flutter Engine from 0d8588b1de7a to 40018811ec0e (6 revisions) (flutter/flutter#144570)
2024-03-04 [email protected] Print warning and exit when iOS device is unpaired (flutter/flutter#144551)
2024-03-04 [email protected] Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) (flutter/flutter#144558)
2024-03-04 [email protected] Remove unnecessary (and the only) `RenderObject.markParentNeedsLayout` override (flutter/flutter#144466)
2024-03-04 [email protected] Fix text color for default CupertinoContextMenuAction (flutter/flutter#144542)
2024-03-04 [email protected] Add missing parameter to `TableBorder.symmetric`, and improve class constructors (flutter/flutter#144279)
2024-03-04 [email protected] Fix build mode not propagated in android native asset build (flutter/flutter#144550)
2024-03-04 [email protected] Roll Packages from a9c68b8 to 0625827 (3 revisions) (flutter/flutter#144556)
2024-03-04 [email protected] Roll Flutter Engine from afd2d9f9421d to a31209171949 (1 revision) (flutter/flutter#144554)
2024-03-04 [email protected] Doc fix for `DropdownButtonFormField.value` (flutter/flutter#144427)
2024-03-04 [email protected] Fix Small Typo in Skia_Client Doc Comment (flutter/flutter#144490)
2024-03-04 [email protected] Roll Flutter Engine from 2338a557e018 to afd2d9f9421d (1 revision) (flutter/flutter#144549)
2024-03-04 [email protected] [Windows] Update keyboard modifiers link (flutter/flutter#144426)
2024-03-04 [email protected] Roll Flutter Engine from 9cbca80e2196 to 2338a557e018 (2 revisions) (flutter/flutter#144545)
2024-03-04 [email protected] Roll Flutter Engine from c52b3033eca6 to 9cbca80e2196 (1 revision) (flutter/flutter#144523)
2024-03-04 [email protected] Roll Flutter Engine from 024ea680ceed to c52b3033eca6 (1 revision) (flutter/flutter#144522)
2024-03-03 [email protected] Roll Flutter Engine from 2706c732b22a to 024ea680ceed (1 revision) (flutter/flutter#144519)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
9b442b2 Print warning and exit when iOS device is unpaired (flutter/f…
27d1770 
…lutter#144551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth vashworth approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter run should detect that targeted iOS devices are unpaired and prompt for how to fix

3 participants

@jmagman @christopherfujino @vashworth