Skip to content

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Mar 1, 2024

fixes showDateRangePicker interactive sample not loading

Description

This fixes showDateRangePicker example not loading in Dartpad.

Similar fix was made for showDatePicker in #99401

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TahaTesser TahaTesser requested a review from bleroux March 1, 2024 14:57
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Mar 1, 2024
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2024
@auto-submit auto-submit bot merged commit 9a83845 into flutter:master Mar 1, 2024
@TahaTesser TahaTesser deleted the showDateRangePicker_sample branch March 1, 2024 15:46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 2, 2024
flutter/flutter@ba719bc...65cd84b

2024-03-02 [email protected] Roll Flutter Engine from 8ef8543d6001 to 2706c732b22a (1 revision) (flutter/flutter#144493)
2024-03-02 [email protected] [github actions] rewrite cherry pick template (flutter/flutter#144065)
2024-03-01 [email protected] Roll Flutter Engine from 2a5a9a6dead0 to 8ef8543d6001 (1 revision) (flutter/flutter#144480)
2024-03-01 [email protected] Roll Packages from 6d02f03 to a9c68b8 (5 revisions) (flutter/flutter#144477)
2024-03-01 [email protected] Fix `showDateRangePicker` is missing `dartpad` tag and cleanup (flutter/flutter#144475)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
flutter/flutter@ba719bc...65cd84b

2024-03-02 [email protected] Roll Flutter Engine from 8ef8543d6001 to 2706c732b22a (1 revision) (flutter/flutter#144493)
2024-03-02 [email protected] [github actions] rewrite cherry pick template (flutter/flutter#144065)
2024-03-01 [email protected] Roll Flutter Engine from 2a5a9a6dead0 to 8ef8543d6001 (1 revision) (flutter/flutter#144480)
2024-03-01 [email protected] Roll Packages from 6d02f03 to a9c68b8 (5 revisions) (flutter/flutter#144477)
2024-03-01 [email protected] Fix `showDateRangePicker` is missing `dartpad` tag and cleanup (flutter/flutter#144475)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

showDateRangePicker interactive sample not loading

2 participants