manual engine roll afaa6b18ad4e5893086b9fe6146514b6b16a907a #144326
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
+dnfield to look at presub failures that might be related to the Android 21 cleanup |
|
|
The framework_tests_misc failures don't look related to my changes. The plugin tests could be. Trying to repro. Staging a revert as well. |
Reverts #51032 Probably causing some of the failures in flutter/flutter#144326 @johnmccutchan fyi
|
roller is going again |
3 participants
afaa6b18ad (HEAD -> roll-afaa6b18ad4e5893086b9fe6146514b6b16a907a, upstream/main, main) Roll Skia from fe34002ee826 to d935943bedcd (1 revision) (flutter/engine#51049)
383e2288e3 Bump everything to Android 21 (flutter/engine#51032)
aebac40133 Add flutter prefix to import (flutter/engine#51042)
1d1c76deb6 Roll Skia from d591703635b0 to fe34002ee826 (1 revision) (flutter/engine#51048)