Reverts "Cache FocusNode.enclosingScope, clean up descendantsAreFocusable (#144207)"
#144292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
github-actions
bot
added
framework
fluttergithubbot
approved these changes
Feb 28, 2024
auto-submit
bot
deleted the
revert_c353cb01231f242732a982c21266e8b7adae8d1d
branch
Contributor
|
\cc @LongCatIsLooong |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 28, 2024
…ntsAreFocusable` (#144207)" (flutter/flutter#144292)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 28, 2024
…ntsAreFocusable` (#144207)" (flutter/flutter#144292)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 28, 2024
…ntsAreFocusable` (#144207)" (flutter/flutter#144292)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 28, 2024
…ntsAreFocusable` (#144207)" (flutter/flutter#144292)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 28, 2024
Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) Manual roll requested by [email protected] flutter/flutter@c30f998...d00bfe8 2024-02-28 [email protected] Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340) 2024-02-28 [email protected] Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338) 2024-02-28 [email protected] Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275) 2024-02-28 [email protected] [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190) 2024-02-28 [email protected] �� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018) 2024-02-28 [email protected] Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316) 2024-02-28 [email protected] Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296) 2024-02-28 [email protected] Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293) 2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292) 2024-02-28 [email protected] Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290) 2024-02-28 [email protected] Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288) 2024-02-28 [email protected] Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285) 2024-02-28 [email protected] Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283) 2024-02-28 [email protected] Use const route for notAnnounced. (flutter/flutter#144050) 2024-02-28 [email protected] Add `tabs_utils.dart` class (flutter/flutter#143937) 2024-02-28 [email protected] Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080) 2024-02-27 [email protected] fix: unexpected chinese punctuation (flutter/flutter#143678) 2024-02-27 [email protected] Clean up lint ignores (flutter/flutter#144229) 2024-02-27 [email protected] Reland [a11y] Add isEnabled semantics flag to text field (flutter/flutter#143601) 2024-02-27 [email protected] Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990) 2024-02-27 [email protected] [iOS] Fix naming in platform_view example (flutter/flutter#144247) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253) 2024-02-27 [email protected] [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130) 2024-02-27 [email protected] Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001) 2024-02-27 [email protected] bind missing add icon in platform_view example (flutter/flutter#132028) 2024-02-27 [email protected] Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207) 2024-02-27 [email protected] Remove strut migration flag from `TextPainter` (flutter/flutter#144242) 2024-02-27 [email protected] Remove force Xcode debug workflow (flutter/flutter#144185) 2024-02-27 [email protected] Mark two other firebase targets as bringup: true (flutter/flutter#144234) 2024-02-27 [email protected] Add FlutterMacOS.xcframework artifact (flutter/flutter#143244) 2024-02-27 [email protected] Re-enable Impeller goldens blocking. (flutter/flutter#144210) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...
LouiseHsu
pushed a commit
to LouiseHsu/packages
that referenced
this pull request
Mar 7, 2024
) Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) Manual roll requested by [email protected] flutter/flutter@c30f998...d00bfe8 2024-02-28 [email protected] Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340) 2024-02-28 [email protected] Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338) 2024-02-28 [email protected] Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275) 2024-02-28 [email protected] [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190) 2024-02-28 [email protected] �� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018) 2024-02-28 [email protected] Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316) 2024-02-28 [email protected] Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296) 2024-02-28 [email protected] Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293) 2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292) 2024-02-28 [email protected] Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290) 2024-02-28 [email protected] Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288) 2024-02-28 [email protected] Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285) 2024-02-28 [email protected] Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283) 2024-02-28 [email protected] Use const route for notAnnounced. (flutter/flutter#144050) 2024-02-28 [email protected] Add `tabs_utils.dart` class (flutter/flutter#143937) 2024-02-28 [email protected] Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080) 2024-02-27 [email protected] fix: unexpected chinese punctuation (flutter/flutter#143678) 2024-02-27 [email protected] Clean up lint ignores (flutter/flutter#144229) 2024-02-27 [email protected] Reland [a11y] Add isEnabled semantics flag to text field (flutter/flutter#143601) 2024-02-27 [email protected] Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990) 2024-02-27 [email protected] [iOS] Fix naming in platform_view example (flutter/flutter#144247) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253) 2024-02-27 [email protected] [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130) 2024-02-27 [email protected] Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001) 2024-02-27 [email protected] bind missing add icon in platform_view example (flutter/flutter#132028) 2024-02-27 [email protected] Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207) 2024-02-27 [email protected] Remove strut migration flag from `TextPainter` (flutter/flutter#144242) 2024-02-27 [email protected] Remove force Xcode debug workflow (flutter/flutter#144185) 2024-02-27 [email protected] Mark two other firebase targets as bringup: true (flutter/flutter#144234) 2024-02-27 [email protected] Add FlutterMacOS.xcframework artifact (flutter/flutter#143244) 2024-02-27 [email protected] Re-enable Impeller goldens blocking. (flutter/flutter#144210) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
…ntsAreFocusable` (#144207)" (flutter/flutter#144292)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #144207
Initiated by: CaseyHillers
Reason for reverting: b/327301206 - Breaking a customer test
Original PR Author: LongCatIsLooong
Reviewed By: {gspencergoog}
This change reverts the following previous change:
Original Description:
FocusNode.canRequestFocuswas doing a double traversal if no ancestor disallows focus. The last for loop only has to reach as far as the enclosing scope.Also this caches the
FocusNode.enclosingScopesince the getter access happens much more frequently than node reparenting.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.