Skip to content

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Feb 27, 2024

Reverts #143244

Initiated by: vashworth

Reason for reverting: Increased flutter_framework_uncompressed_bytes - see #144251

Original PR Author: vashworth

Reviewed By: {jmagman}

This change reverts the following previous change:
Original Description:
Replace FlutterMacOS.framework cached artifact with FlutterMacOS.xcframework. Also, update usage of FlutterMacOS.framework to use FlutterMacOS.xcframework.

Part of #126016.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Feb 27, 2024
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 27, 2024
@auto-submit auto-submit bot merged commit 7f2b238 into master Feb 27, 2024
@auto-submit auto-submit bot deleted the revert_42252cd4c64e6456bb368ff8876fd4e9d7e15c00 branch February 27, 2024 20:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 28, 2024
Manual roll Flutter from c30f998 to d00bfe8 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@c30f998...d00bfe8

2024-02-28 [email protected] Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340)
2024-02-28 [email protected] Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338)
2024-02-28 [email protected] Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275)
2024-02-28 [email protected] [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190)
2024-02-28 [email protected] ð��¡ï¸� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018)
2024-02-28 [email protected] Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316)
2024-02-28 [email protected] Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296)
2024-02-28 [email protected] Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293)
2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292)
2024-02-28 [email protected] Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290)
2024-02-28 [email protected] Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288)
2024-02-28 [email protected] Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285)
2024-02-28 [email protected] Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283)
2024-02-28 [email protected] Use const route for notAnnounced. (flutter/flutter#144050)
2024-02-28 [email protected] Add `tabs_utils.dart` class (flutter/flutter#143937)
2024-02-28 [email protected] Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080)
2024-02-27 [email protected] fix: unexpected chinese punctuation (flutter/flutter#143678)
2024-02-27 [email protected] Clean up lint ignores (flutter/flutter#144229)
2024-02-27 [email protected] Reland [a11y] Add isEnabled semantics flag to  text field  (flutter/flutter#143601)
2024-02-27 [email protected] Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990)
2024-02-27 [email protected] [iOS] Fix naming in platform_view example (flutter/flutter#144247)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253)
2024-02-27 [email protected] [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130)
2024-02-27 [email protected] Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001)
2024-02-27 [email protected] bind missing add icon in platform_view example (flutter/flutter#132028)
2024-02-27 [email protected] Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207)
2024-02-27 [email protected] Remove strut migration flag from `TextPainter` (flutter/flutter#144242)
2024-02-27 [email protected] Remove force Xcode debug workflow (flutter/flutter#144185)
2024-02-27 [email protected] Mark two other firebase targets as bringup: true (flutter/flutter#144234)
2024-02-27 [email protected] Add FlutterMacOS.xcframework artifact (flutter/flutter#143244)
2024-02-27 [email protected] Re-enable Impeller goldens blocking.  (flutter/flutter#144210)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
)

Manual roll Flutter from c30f998 to d00bfe8 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@c30f998...d00bfe8

2024-02-28 [email protected] Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340)
2024-02-28 [email protected] Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338)
2024-02-28 [email protected] Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275)
2024-02-28 [email protected] [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190)
2024-02-28 [email protected] ð��¡ï¸� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018)
2024-02-28 [email protected] Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316)
2024-02-28 [email protected] Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296)
2024-02-28 [email protected] Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293)
2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292)
2024-02-28 [email protected] Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290)
2024-02-28 [email protected] Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288)
2024-02-28 [email protected] Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285)
2024-02-28 [email protected] Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283)
2024-02-28 [email protected] Use const route for notAnnounced. (flutter/flutter#144050)
2024-02-28 [email protected] Add `tabs_utils.dart` class (flutter/flutter#143937)
2024-02-28 [email protected] Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080)
2024-02-27 [email protected] fix: unexpected chinese punctuation (flutter/flutter#143678)
2024-02-27 [email protected] Clean up lint ignores (flutter/flutter#144229)
2024-02-27 [email protected] Reland [a11y] Add isEnabled semantics flag to  text field  (flutter/flutter#143601)
2024-02-27 [email protected] Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990)
2024-02-27 [email protected] [iOS] Fix naming in platform_view example (flutter/flutter#144247)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253)
2024-02-27 [email protected] [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130)
2024-02-27 [email protected] Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001)
2024-02-27 [email protected] bind missing add icon in platform_view example (flutter/flutter#132028)
2024-02-27 [email protected] Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207)
2024-02-27 [email protected] Remove strut migration flag from `TextPainter` (flutter/flutter#144242)
2024-02-27 [email protected] Remove force Xcode debug workflow (flutter/flutter#144185)
2024-02-27 [email protected] Mark two other firebase targets as bringup: true (flutter/flutter#144234)
2024-02-27 [email protected] Add FlutterMacOS.xcframework artifact (flutter/flutter#143244)
2024-02-27 [email protected] Re-enable Impeller goldens blocking.  (flutter/flutter#144210)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants