Revert "Re-enable Impeller goldens blocking. (#144023)" #144115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the current head some tests (such as test/widgets/shadow_test.dart) are segfaulting in the Impeller Vulkan back end. This reverts commit 39585e6.
zanderso
approved these changes
Feb 26, 2024
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 26, 2024
flutter/flutter@1e8dd1e...b77560e 2024-02-26 [email protected] Roll Flutter Engine from 32d7f9f0f546 to a15326b2c439 (1 revision) (flutter/flutter#144143) 2024-02-26 [email protected] Fix `Scrollbar.thickness` property is ignored when the `Scrollbar` is hovered (flutter/flutter#144012) 2024-02-26 [email protected] Roll Flutter Engine from 168cc5c0a195 to 32d7f9f0f546 (1 revision) (flutter/flutter#144128) 2024-02-26 [email protected] Roll Flutter Engine from 330e743203b0 to 168cc5c0a195 (1 revision) (flutter/flutter#144125) 2024-02-26 [email protected] Roll Flutter Engine from fd3136782aae to 330e743203b0 (1 revision) (flutter/flutter#144123) 2024-02-26 [email protected] Roll Flutter Engine from f372329c9099 to fd3136782aae (1 revision) (flutter/flutter#144118) 2024-02-26 [email protected] Roll Flutter Engine from da3d49c30bcc to f372329c9099 (2 revisions) (flutter/flutter#144117) 2024-02-26 [email protected] Revert "Re-enable Impeller goldens blocking. (#144023)" (flutter/flutter#144115) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
pushed a commit
that referenced
this pull request
Feb 27, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
The issues in #144115 should be fixed with the removal of the incorrect render pass caching behavior in flutter/engine#50976
LouiseHsu
pushed a commit
to LouiseHsu/packages
that referenced
this pull request
Mar 7, 2024
flutter/flutter@1e8dd1e...b77560e 2024-02-26 [email protected] Roll Flutter Engine from 32d7f9f0f546 to a15326b2c439 (1 revision) (flutter/flutter#144143) 2024-02-26 [email protected] Fix `Scrollbar.thickness` property is ignored when the `Scrollbar` is hovered (flutter/flutter#144012) 2024-02-26 [email protected] Roll Flutter Engine from 168cc5c0a195 to 32d7f9f0f546 (1 revision) (flutter/flutter#144128) 2024-02-26 [email protected] Roll Flutter Engine from 330e743203b0 to 168cc5c0a195 (1 revision) (flutter/flutter#144125) 2024-02-26 [email protected] Roll Flutter Engine from fd3136782aae to 330e743203b0 (1 revision) (flutter/flutter#144123) 2024-02-26 [email protected] Roll Flutter Engine from f372329c9099 to fd3136782aae (1 revision) (flutter/flutter#144118) 2024-02-26 [email protected] Roll Flutter Engine from da3d49c30bcc to f372329c9099 (2 revisions) (flutter/flutter#144117) 2024-02-26 [email protected] Revert "Re-enable Impeller goldens blocking. (#144023)" (flutter/flutter#144115) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the current head some tests (such as test/widgets/shadow_test.dart) are segfaulting in the Impeller Vulkan back end.
This reverts commit 39585e6.
See #144116