Run tests on iOS 17 exclusively #144022

vashworth · 2024-02-23T16:04:36Z

Almost all of our devicelab devices are on iOS 17 now, so let's use them exclusively so we can verify that tests pass consistently on iOS 17.

Fixes #144020.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

keyonghan

LGTM

flutter/flutter@41581c9...39585e6 2024-02-23 [email protected] Re-enable Impeller goldens blocking. (flutter/flutter#144023) 2024-02-23 [email protected] Roll Flutter Engine from 0f3ad23b84ed to 5f99a6c3289e (16 revisions) (flutter/flutter#144028) 2024-02-23 [email protected] Roll Packages from 078c2a3 to 7df2085 (3 revisions) (flutter/flutter#144030) 2024-02-23 [email protected] Run tests on iOS 17 exclusively (flutter/flutter#144022) 2024-02-23 [email protected] Retry button tap in [FlutterUITests testFlutterViewWarm] (flutter/flutter#143967) 2024-02-23 [email protected] Remove deprecated `InteractiveViewer.alignPanAxis` (flutter/flutter#142500) 2024-02-23 [email protected] Remove deprecated `KeepAliveHandle.release` (flutter/flutter#143961) 2024-02-23 [email protected] Remove deprecated AnimatedListItemBuilder, AnimatedListRemovedItemBuilder (flutter/flutter#143974) 2024-02-23 [email protected] Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revisions) (flutter/flutter#143989) 2024-02-23 [email protected] Remove deprecated TimelineSummary.writeSummaryToFile (flutter/flutter#143983) 2024-02-23 [email protected] Remove unused drone_dimension field (flutter/flutter#143984) 2024-02-23 [email protected] Remove deprecated MediaQuery.boldTextOverride (flutter/flutter#143960) 2024-02-22 [email protected] Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (flutter/flutter#143986) 2024-02-22 [email protected] Remove deprecated FlutterDriver.enableAccessibility (flutter/flutter#143979) 2024-02-22 [email protected] Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (flutter/flutter#143980) 2024-02-22 [email protected] Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#143973) 2024-02-22 [email protected] Add CloseButtonTooltip to the 'X' button on a SnackBar (flutter/flutter#143934) 2024-02-22 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/flutter#143971) 2024-02-22 [email protected] Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (flutter/flutter#143972) 2024-02-22 [email protected] Use inlining annotations on important methods for all targets (flutter/flutter#143923) 2024-02-22 [email protected] Add missing `TextPainter.strutStyle` to paragraph style (flutter/flutter#143771) 2024-02-22 [email protected] Shift Moto G4 staging tests to A02s (flutter/flutter#143957) 2024-02-22 [email protected] Add CurvedAnimation disposals in some widgets (flutter/flutter#143790) 2024-02-22 [email protected] Fix documentation typo in basic.dart (flutter/flutter#143887) 2024-02-22 [email protected] Fixed Small Typo in Emulators Test Name (flutter/flutter#143578) 2024-02-22 [email protected] Support using lightweight Flutter Engines to run tests (flutter/flutter#141726) 2024-02-22 [email protected] Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (flutter/flutter#143943) 2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutter/flutter#143946) 2024-02-22 [email protected] Roll Packages from 48048f6 to 078c2a3 (11 revisions) (flutter/flutter#143935) 2024-02-22 [email protected] Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (flutter/flutter#143933) 2024-02-22 [email protected] Reland Add UI Benchmarks (#143542) (flutter/flutter#143799) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutteractionsbot · 2024-03-14T21:02:43Z

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

Almost all of our devicelab devices are on iOS 17 now, so let's use them exclusively so we can verify that tests pass consistently on iOS 17. Fixes flutter#144020.

XilaiZhang · 2024-03-14T21:21:41Z

Thanks a lot for trying out the actions bot!

By the way was there a real merge conflict that prevented the auto cherry pick ( i.e. you also resolved a conflict when manually doing the cherry pick ), or is it a false positive from the actions bot? Thank you!

vashworth · 2024-03-15T14:53:31Z

Thanks a lot for trying out the actions bot!

By the way was there a real merge conflict that prevented the auto cherry pick ( i.e. you also resolved a conflict when manually doing the cherry pick ), or is it a false positive from the actions bot? Thank you!

It did have an actual merge conflict I had to manually resolve.

Original PR: #144022

Original PR: flutter#144022

Run tests on iOS 17 exclusively

879b6dc

vashworth marked this pull request as ready for review February 23, 2024 16:48

vashworth requested a review from keyonghan February 23, 2024 16:48

vashworth mentioned this pull request Feb 23, 2024

[Impeller] Apparent regression in backdrop filter benchmark #143945

Closed

keyonghan approved these changes Feb 23, 2024

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 23, 2024

auto-submit bot merged commit bb85607 into flutter:master Feb 23, 2024

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to bb856079c401 (28 revisions) flutter/packages#6190

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

bb85607 Run tests on iOS 17 exclusively (flutter/flutter#144022)

fb1834d

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to bab5f85df560 (29 revisions) flutter/packages#6193

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

bb85607 Run tests on iOS 17 exclusively (flutter/flutter#144022)

fa046c4

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to 39585e66c11f (31 revisions) flutter/packages#6194

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

bb85607 Run tests on iOS 17 exclusively (flutter/flutter#144022)

90263e7

vashworth mentioned this pull request Feb 28, 2024

Allow stable and beta branches to run tests on iOS 17 #143003

Closed

8 tasks

vashworth added the cp: stable cherry pick this pull request to stable release candidate branch label Mar 14, 2024

vashworth mentioned this pull request Mar 14, 2024

[CP] Run tests on iOS 17 exclusively (#144022) #145181

Merged

9 tasks

auto-submit bot pushed a commit that referenced this pull request Mar 23, 2024

[CP] Run tests on iOS 17 exclusively (#144022) (#145181)

f1f4106

Original PR: #144022

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

bb85607 Run tests on iOS 17 exclusively (flutter/flutter#144022)

cd48a31

danielatego pushed a commit to danielatego/flutter that referenced this pull request Jun 6, 2024

[CP] Run tests on iOS 17 exclusively (flutter#144022) (flutter#145181)

794aa45

Original PR: flutter#144022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Run tests on iOS 17 exclusively #144022

Run tests on iOS 17 exclusively #144022

Uh oh!

vashworth commented Feb 23, 2024

Uh oh!

keyonghan left a comment

Uh oh!

flutteractionsbot commented Mar 14, 2024

Uh oh!

XilaiZhang commented Mar 14, 2024

Uh oh!

vashworth commented Mar 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Run tests on iOS 17 exclusively #144022

Run tests on iOS 17 exclusively #144022

Uh oh!

Conversation

vashworth commented Feb 23, 2024

Pre-launch Checklist

Uh oh!

keyonghan left a comment

Choose a reason for hiding this comment

Uh oh!

flutteractionsbot commented Mar 14, 2024

Uh oh!

XilaiZhang commented Mar 14, 2024

Uh oh!

vashworth commented Mar 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants