Update inherited_theme_test.dart, ink_paint_test.dart, ink_splash_test.dart, opacity_test.dart for Material 3
#144013
Conversation
github-actions
bot
added
framework
TahaTesser
force-pushed
the
update_tests_for_m3
branch
from
b1d1df1 to
c755513
Compare
TahaTesser
force-pushed
the
update_tests_for_m3
branch
3 times, most recently
from
19ca638 to
3b2fc2f
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #144013 at sha 3b2fc2f2ed69f38b71605ead9d70e894596e4de8 |
|
FYI, I just added a new shard that generates goldens an hour or so after you opened this PR, so you should make sure to update branch before landing this so you pick them up. |
TahaTesser
force-pushed
the
update_tests_for_m3
branch
from
3b2fc2f to
0f7b37b
Compare
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #144013 at sha 0f7b37b97a32ee5ed7a5f5baef497b44f4c15415 |
TahaTesser
force-pushed
the
update_tests_for_m3
branch
from
0f7b37b to
b99795a
Compare
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #144013 at sha b99795ab6625172789e607970914011d9dee4f43 |
…h_test.dart`, `opacity_test.dart` for Mater
TahaTesser
force-pushed
the
update_tests_for_m3
branch
from
b99795a to
a6abbe5
Compare
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
TahaTesser
added
the
autosubmit
…nk_splash_test.dart`, `opacity_test.dart` for Material 3 (flutter/flutter#144013)
…nk_splash_test.dart`, `opacity_test.dart` for Material 3 (flutter/flutter#144013)
flutter/flutter@7c860dd...f217fc1 2024-03-18 [email protected] Roll Packages from 756dcc1 to a757073 (3 revisions) (flutter/flutter#145325) 2024-03-18 [email protected] Roll Flutter Engine from f11015e14d24 to 86de0f75606f (1 revision) (flutter/flutter#145322) 2024-03-18 [email protected] InputDecorator M3 tests migration - Step6 - constraints (flutter/flutter#145213) 2024-03-18 [email protected] Update `inherited_theme_test.dart`, `ink_paint_test.dart`, `ink_splash_test.dart`, `opacity_test.dart` for Material 3 (flutter/flutter#144013) 2024-03-18 [email protected] Roll Flutter Engine from eac9db75f902 to f11015e14d24 (2 revisions) (flutter/flutter#145321) 2024-03-18 [email protected] Roll Flutter Engine from aebc0021cd18 to eac9db75f902 (1 revision) (flutter/flutter#145308) 2024-03-18 [email protected] Roll Flutter Engine from 89c775963926 to aebc0021cd18 (1 revision) (flutter/flutter#145305) 2024-03-18 [email protected] Roll Flutter Engine from 5c31faa15ab7 to 89c775963926 (1 revision) (flutter/flutter#145303) 2024-03-17 [email protected] Roll Flutter Engine from 4c420dd2dfd9 to 5c31faa15ab7 (2 revisions) (flutter/flutter#145294) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…nk_splash_test.dart`, `opacity_test.dart` for Material 3 (flutter/flutter#144013)
3 participants
Updated unit tests for
Tooltipto have M2 and M3 versions.More info in #139076
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.