Skip to content

Fix Scrollbar.thickness property is ignored when the Scrollbar is hovered #144012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 26, 2024
Merged

Fix Scrollbar.thickness property is ignored when the Scrollbar is hovered #144012

auto-submit merged 1 commit into from
Feb 26, 2024

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Feb 23, 2024

fixes Scrollbar.thickness property is ignored when the Scrollbar is hovered

Code sample

expand to view the code sample 
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    final ScrollController scrollController = ScrollController();

    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Material(
        child: ScrollConfiguration(
          behavior: const NoScrollbarBehavior(),
          child: ScrollbarTheme(
            data: ScrollbarThemeData(
              thickness: MaterialStateProperty.all(25.0),
              showTrackOnHover: true,
            ),
            child: Scrollbar(
              thickness: 50.0,
              thumbVisibility: true,
              radius: const Radius.circular(3.0),
              controller: scrollController,
              child: SingleChildScrollView(
                controller: scrollController,
                child: const SizedBox(width: 4000.0, height: 4000.0),
              ),
            ),
          ),
        ),
      ),
    );
  }
}

class NoScrollbarBehavior extends ScrollBehavior {
  const NoScrollbarBehavior();

  @override
  Widget buildScrollbar(
          BuildContext context, Widget child, ScrollableDetails details) =>
      child;
}

Preview

Before After

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. labels Feb 23, 2024
@TahaTesser TahaTesser requested a review from Piinks February 23, 2024 14:16
@TahaTesser TahaTesser marked this pull request as ready for review February 23, 2024 14:16
Piinks
Piinks approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This is one of those that make me think - gosh how did this bug live here for so long! 🐛

packages/flutter/test/material/scrollbar_theme_test.dart Outdated
Copy link
Contributor

@Piinks Piinks Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice readability improvement! 👍

@TahaTesser TahaTesser force-pushed the fix_scrollbar_thickness_hovered branch from e4f3620 to a2ea844 Compare February 26, 2024 08:31
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2024
@auto-submit auto-submit bot merged commit 41b1aea into flutter:master Feb 26, 2024
@TahaTesser TahaTesser deleted the fix_scrollbar_thickness_hovered branch February 26, 2024 10:37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2024
@engine-flutter-autoroll
41b1aea Fix Scrollbar.thickness property is ignored when the `Scrol…
2be8518 
…lbar` is hovered (flutter/flutter#144012)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2024
@engine-flutter-autoroll
41b1aea Fix Scrollbar.thickness property is ignored when the `Scrol…
f8968ce 
…lbar` is hovered (flutter/flutter#144012)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 26, 2024
@engine-flutter-autoroll
Roll Flutter from 1e8dd1e to b77560e (8 revisions) (#6207)
f9171d1 
flutter/flutter@1e8dd1e...b77560e

2024-02-26 [email protected] Roll Flutter Engine from 32d7f9f0f546 to a15326b2c439 (1 revision) (flutter/flutter#144143)
2024-02-26 [email protected] Fix `Scrollbar.thickness` property is ignored when the `Scrollbar` is hovered (flutter/flutter#144012)
2024-02-26 [email protected] Roll Flutter Engine from 168cc5c0a195 to 32d7f9f0f546 (1 revision) (flutter/flutter#144128)
2024-02-26 [email protected] Roll Flutter Engine from 330e743203b0 to 168cc5c0a195 (1 revision) (flutter/flutter#144125)
2024-02-26 [email protected] Roll Flutter Engine from fd3136782aae to 330e743203b0 (1 revision) (flutter/flutter#144123)
2024-02-26 [email protected] Roll Flutter Engine from f372329c9099 to fd3136782aae (1 revision) (flutter/flutter#144118)
2024-02-26 [email protected] Roll Flutter Engine from da3d49c30bcc to f372329c9099 (2 revisions) (flutter/flutter#144117)
2024-02-26 [email protected] Revert "Re-enable Impeller goldens blocking. (#144023)" (flutter/flutter#144115)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll @LouiseHsu
Roll Flutter from 1e8dd1e to b77560e (8 revisions) (flutter#6207)
041151a 
flutter/flutter@1e8dd1e...b77560e

2024-02-26 [email protected] Roll Flutter Engine from 32d7f9f0f546 to a15326b2c439 (1 revision) (flutter/flutter#144143)
2024-02-26 [email protected] Fix `Scrollbar.thickness` property is ignored when the `Scrollbar` is hovered (flutter/flutter#144012)
2024-02-26 [email protected] Roll Flutter Engine from 168cc5c0a195 to 32d7f9f0f546 (1 revision) (flutter/flutter#144128)
2024-02-26 [email protected] Roll Flutter Engine from 330e743203b0 to 168cc5c0a195 (1 revision) (flutter/flutter#144125)
2024-02-26 [email protected] Roll Flutter Engine from fd3136782aae to 330e743203b0 (1 revision) (flutter/flutter#144123)
2024-02-26 [email protected] Roll Flutter Engine from f372329c9099 to fd3136782aae (1 revision) (flutter/flutter#144118)
2024-02-26 [email protected] Roll Flutter Engine from da3d49c30bcc to f372329c9099 (2 revisions) (flutter/flutter#144117)
2024-02-26 [email protected] Revert "Re-enable Impeller goldens blocking. (#144023)" (flutter/flutter#144115)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Mar 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
41b1aea Fix Scrollbar.thickness property is ignored when the `Scrol…
e5f483f 
…lbar` is hovered (flutter/flutter#144012)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scrollbar.thickness property is ignored when the Scrollbar is hovered

2 participants

@TahaTesser @Piinks