[CP-stable]instead of exiting the tool, print a warning when using --flavor with an incompatible device #143785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an incompatible device (flutter#143735) Fixes flutter#143574 by printing a warning (instead of exiting) when `--flavor` is used with a target platform that doesn't have flavors support.
Author
|
@andrewkolos please fill out the PR description above, afterwards the release team will review this request. |
github-actions
bot
added
the
tool
christopherfujino
approved these changes
Feb 20, 2024
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM, this is a very safe fix to a regression that made certain workflows impossible, and the workaround annoying.
XilaiZhang
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 21, 2024
…n using --flavor with an incompatible device (flutter/flutter#143785)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2024
…n using --flavor with an incompatible device (flutter/flutter#143785)
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 2, 2024
Context: @godofredoc pointed out that the fields in the PR template could be simplified and redesigned. Synced with @itsjustkevin and Kevin come up with [changes in this doc](https://docs.google.com/document/d/1Slppqq32toSwwxUyYTX1t6dGUQpyi0xEWxw4niGWspc/edit?resourcekey=0-v6U_9XVsMFSx0Fvx1rANhg&tab=t.0) which would improve the cherry pick template. Github only supports a limited number of formatting options. This PR uses some workarounds and makes the following changes: 1. use divider to replace text area since Github markdown doesn't support text area 2. remove \<pre\> tags so texts can wrap around 3. use headings over bold 4. use task lists to identify the starting points of user answers An example cherry pick template would [look like this](#143785) after the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#143574
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Instead of exiting, the
flutterCLI tool now prints a warning when the--flavoroption is used with a target platform that doesn't have flavors support.impact_description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
All Flutter devs using the Flavors feature that use their IDE to select a target device.
Workaround:
Is there a workaround for this issue?
Users can create duplicate debug launch configurations for target platforms that do not support the flavors feature.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Set up a flutter project and configure at least one flavor for it. In VSCode, create a launch configuration that uses
--flavorto select the flavor you configured (see #143574 (comment) for an example). In VSCode, select chrome as the target device and try running the application using the configured launch configuration.