Skip to content

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented Feb 16, 2024

I don't intend to land this, I just noticed that the FTL failures started in this repo on a commit that was an engine roll, which makes me ever so slightly suspicious that it could be the case that there is an actual failure. So I want to see if the tests pass on a revert of the roll, and I don't know how to run these FTL tests without making CI do it 🙂

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Feb 16, 2024
@gmackall gmackall closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant