[flutter_test] Use defaultTargetPlatform for key events simulation #143579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: tests
bleroux
force-pushed
the
use_defaultTargetPlatform_for_key_event_simulation
branch
from
f78ab4b to
68e3bf9
Compare
Contributor
Yes, this is all going to be irrelevant once the raw key event stuff is finally removed next January. But I think it's fine to do this now: it'll be used for a year or so at least. |
Contributor
Author
|
I'm currently investivating the customer test failures for this PR. |
This was referenced Feb 21, 2024
bleroux
force-pushed
the
use_defaultTargetPlatform_for_key_event_simulation
branch
from
68e3bf9 to
a91b82e
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 7, 2024
flutter/flutter@8f84f3f...471a828 2024-03-07 [email protected] [flutter_test] Use defaultTargetPlatform for key events simulation (flutter/flutter#143579) 2024-03-07 [email protected] Roll Packages from 9b88dbc to 6701c9e (3 revisions) (flutter/flutter#144772) 2024-03-07 [email protected] Fix frameworks added to bundle multiple times instead of lipo (flutter/flutter#144688) 2024-03-07 [email protected] Roll Flutter Engine from 40a42796b129 to f8c3b2db8cd1 (1 revision) (flutter/flutter#144766) 2024-03-07 [email protected] Roll Flutter Engine from 0246484d2bae to 40a42796b129 (1 revision) (flutter/flutter#144765) 2024-03-07 [email protected] Roll Flutter Engine from 6c1751bd774e to 0246484d2bae (1 revision) (flutter/flutter#144756) 2024-03-07 [email protected] [flutter_test] Change KeyEventSimulator default transit mode (flutter/flutter#143847) 2024-03-07 [email protected] Roll Flutter Engine from 03ebd6460b83 to 6c1751bd774e (2 revisions) (flutter/flutter#144747) 2024-03-07 [email protected] Roll Flutter Engine from 8a859c5b3a2d to 03ebd6460b83 (2 revisions) (flutter/flutter#144746) 2024-03-07 [email protected] Roll Flutter Engine from 4f6ea31d1f25 to 8a859c5b3a2d (2 revisions) (flutter/flutter#144743) 2024-03-07 [email protected] Fix memory leak in `editable_gesture_test.dart` (flutter/flutter#144691) 2024-03-07 [email protected] Roll Flutter Engine from 53ddbdfc24e5 to 4f6ea31d1f25 (2 revisions) (flutter/flutter#144741) 2024-03-07 [email protected] Roll Flutter Engine from b2adf7471d3d to 53ddbdfc24e5 (1 revision) (flutter/flutter#144735) 2024-03-06 [email protected] Roll Flutter Engine from 31bbe61dfa0d to b2adf7471d3d (1 revision) (flutter/flutter#144732) 2024-03-06 [email protected] Roll Flutter Engine from 5bbac1a5c576 to 31bbe61dfa0d (3 revisions) (flutter/flutter#144724) 2024-03-06 [email protected] Run macOS test on `dev/integration_tests/ui` (flutter/flutter#142735) 2024-03-06 [email protected] Use wasm-compatible conditional import in timeline.dart, avoid emitting timeline events in SchedulerBinding (flutter/flutter#144682) 2024-03-06 [email protected] Roll Flutter Engine from 44405aedba13 to 5bbac1a5c576 (2 revisions) (flutter/flutter#144714) 2024-03-06 [email protected] Bring back firebase tests to prod (flutter/flutter#144703) 2024-03-06 [email protected] Roll Flutter Engine from 20037e385bda to 44405aedba13 (3 revisions) (flutter/flutter#144710) 2024-03-06 [email protected] Fix code sample failing in smoke test (flutter/flutter#144709) 2024-03-06 [email protected] Remove deprecated `errorColor` from `ThemeData` (flutter/flutter#144078) 2024-03-06 [email protected] make DevFSContent descendants immutable (flutter/flutter#144664) 2024-03-06 [email protected] [Impeller] measure GPU memory usage. (flutter/flutter#144575) 2024-03-06 [email protected] Roll Flutter Engine from 9aad0e93899b to 20037e385bda (1 revision) (flutter/flutter#144707) 2024-03-06 [email protected] Roll Flutter Engine from b6efe0dd88fe to 9aad0e93899b (2 revisions) (flutter/flutter#144702) 2024-03-06 [email protected] Update android templates to use target sdk 34 (flutter/flutter#144641) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
Time to revert pull request flutter/flutter/143579 has elapsed. |
auto-submit
bot
removed
the
revert
itsjustkevin
added a commit
to itsjustkevin/flutter
that referenced
this pull request
Mar 8, 2024
…ation (flutter#143579)" This reverts commit 471a828.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PRs changes the default value for the
platformparameter used to simulate key events.With this PR, the default value is "web" on web, otherwise it is the operating system name retrieved from
defaultTargetPlatform.Previously, for methods in
WidgetController, it defaulted to “web” on web, and “android” everywhere else. And for methods inKeyEventSimulatorit defaulted to “web” on web, and the operating system that the test was running on everywhere else. Because the operating system was based onPlatform.operatingSystem, it usually differed from the target platform the test was running on.AFAIK, the
platformparameter is only meaningful for simulatingRawKeyEvent. OnceRawKeyboardwill be fully removed, theplatformparameter won’t be needed.@gspencergoog In the meantime, do you think it is worth merging this fix?
Related Issue
Fixes #133955
Tests
Adds one test.