Skip to content

Fixed Small Typo in Emulators Test Name #143578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 22, 2024
Merged

Fixed Small Typo in Emulators Test Name #143578

auto-submit merged 1 commit into from
Feb 22, 2024

Conversation

@piedcipher
Copy link
Member

@piedcipher piedcipher commented Feb 16, 2024 •
edited
Loading

Fixed Small Typo in Emulators Test Name. I filed #140656 and it was fixed in #142853. I noticed this one there and decided to send a fix.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@piedcipher piedcipher changed the title Fixed Small Typo in Test Name Fixed Small Typo in Emulators Test Name Feb 16, 2024
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 16, 2024
goderbauer
goderbauer approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bernaferrari
Copy link
Contributor

bernaferrari commented Feb 22, 2024

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2024
@auto-submit auto-submit bot merged commit 3053b6c into flutter:master Feb 22, 2024
@piedcipher piedcipher deleted the fix/typo branch February 22, 2024 18:35
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
3053b6c Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
afa150a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
3053b6c Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
7a7d58f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
3053b6c Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
dcaaa03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
3053b6c Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
4548c47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
3053b6c Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
48c916c
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
Roll Flutter from 41581c9 to 39585e6 (31 revisions) (#6194)
fe6111b 
flutter/flutter@41581c9...39585e6

2024-02-23 [email protected] Re-enable Impeller goldens blocking. (flutter/flutter#144023)
2024-02-23 [email protected] Roll Flutter Engine from 0f3ad23b84ed to 5f99a6c3289e (16 revisions) (flutter/flutter#144028)
2024-02-23 [email protected] Roll Packages from 078c2a3 to 7df2085 (3 revisions) (flutter/flutter#144030)
2024-02-23 [email protected] Run tests on iOS 17 exclusively (flutter/flutter#144022)
2024-02-23 [email protected] Retry button tap in [FlutterUITests testFlutterViewWarm] (flutter/flutter#143967)
2024-02-23 [email protected] Remove deprecated `InteractiveViewer.alignPanAxis` (flutter/flutter#142500)
2024-02-23 [email protected] Remove deprecated `KeepAliveHandle.release` (flutter/flutter#143961)
2024-02-23 [email protected] Remove deprecated AnimatedListItemBuilder, AnimatedListRemovedItemBuilder (flutter/flutter#143974)
2024-02-23 [email protected] Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revisions) (flutter/flutter#143989)
2024-02-23 [email protected] Remove deprecated TimelineSummary.writeSummaryToFile (flutter/flutter#143983)
2024-02-23 [email protected] Remove unused drone_dimension field (flutter/flutter#143984)
2024-02-23 [email protected] Remove deprecated MediaQuery.boldTextOverride (flutter/flutter#143960)
2024-02-22 [email protected] Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (flutter/flutter#143986)
2024-02-22 [email protected] Remove deprecated FlutterDriver.enableAccessibility (flutter/flutter#143979)
2024-02-22 [email protected] Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (flutter/flutter#143980)
2024-02-22 [email protected] Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#143973)
2024-02-22 [email protected] Add CloseButtonTooltip to the 'X' button on a SnackBar (flutter/flutter#143934)
2024-02-22 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/flutter#143971)
2024-02-22 [email protected] Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (flutter/flutter#143972)
2024-02-22 [email protected] Use inlining annotations on important methods for all targets (flutter/flutter#143923)
2024-02-22 [email protected] Add missing `TextPainter.strutStyle` to paragraph style (flutter/flutter#143771)
2024-02-22 [email protected] Shift Moto G4 staging tests to A02s (flutter/flutter#143957)
2024-02-22 [email protected] Add CurvedAnimation disposals in some widgets (flutter/flutter#143790)
2024-02-22 [email protected] Fix documentation typo in basic.dart (flutter/flutter#143887)
2024-02-22 [email protected] Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
2024-02-22 [email protected] Support using lightweight Flutter Engines to run tests (flutter/flutter#141726)
2024-02-22 [email protected] Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (flutter/flutter#143943)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutter/flutter#143946)
2024-02-22 [email protected] Roll Packages from 48048f6 to 078c2a3 (11 revisions) (flutter/flutter#143935)
2024-02-22 [email protected] Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (flutter/flutter#143933)
2024-02-22 [email protected] Reland Add UI Benchmarks (#143542) (flutter/flutter#143799)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll @LouiseHsu
Roll Flutter from 41581c9 to 39585e6 (31 revisions) (flutter#6194)
84dc5ff 
flutter/flutter@41581c9...39585e6

2024-02-23 [email protected] Re-enable Impeller goldens blocking. (flutter/flutter#144023)
2024-02-23 [email protected] Roll Flutter Engine from 0f3ad23b84ed to 5f99a6c3289e (16 revisions) (flutter/flutter#144028)
2024-02-23 [email protected] Roll Packages from 078c2a3 to 7df2085 (3 revisions) (flutter/flutter#144030)
2024-02-23 [email protected] Run tests on iOS 17 exclusively (flutter/flutter#144022)
2024-02-23 [email protected] Retry button tap in [FlutterUITests testFlutterViewWarm] (flutter/flutter#143967)
2024-02-23 [email protected] Remove deprecated `InteractiveViewer.alignPanAxis` (flutter/flutter#142500)
2024-02-23 [email protected] Remove deprecated `KeepAliveHandle.release` (flutter/flutter#143961)
2024-02-23 [email protected] Remove deprecated AnimatedListItemBuilder, AnimatedListRemovedItemBuilder (flutter/flutter#143974)
2024-02-23 [email protected] Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revisions) (flutter/flutter#143989)
2024-02-23 [email protected] Remove deprecated TimelineSummary.writeSummaryToFile (flutter/flutter#143983)
2024-02-23 [email protected] Remove unused drone_dimension field (flutter/flutter#143984)
2024-02-23 [email protected] Remove deprecated MediaQuery.boldTextOverride (flutter/flutter#143960)
2024-02-22 [email protected] Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (flutter/flutter#143986)
2024-02-22 [email protected] Remove deprecated FlutterDriver.enableAccessibility (flutter/flutter#143979)
2024-02-22 [email protected] Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (flutter/flutter#143980)
2024-02-22 [email protected] Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#143973)
2024-02-22 [email protected] Add CloseButtonTooltip to the 'X' button on a SnackBar (flutter/flutter#143934)
2024-02-22 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/flutter#143971)
2024-02-22 [email protected] Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (flutter/flutter#143972)
2024-02-22 [email protected] Use inlining annotations on important methods for all targets (flutter/flutter#143923)
2024-02-22 [email protected] Add missing `TextPainter.strutStyle` to paragraph style (flutter/flutter#143771)
2024-02-22 [email protected] Shift Moto G4 staging tests to A02s (flutter/flutter#143957)
2024-02-22 [email protected] Add CurvedAnimation disposals in some widgets (flutter/flutter#143790)
2024-02-22 [email protected] Fix documentation typo in basic.dart (flutter/flutter#143887)
2024-02-22 [email protected] Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
2024-02-22 [email protected] Support using lightweight Flutter Engines to run tests (flutter/flutter#141726)
2024-02-22 [email protected] Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (flutter/flutter#143943)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutter/flutter#143946)
2024-02-22 [email protected] Roll Packages from 48048f6 to 078c2a3 (11 revisions) (flutter/flutter#143935)
2024-02-22 [email protected] Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (flutter/flutter#143933)
2024-02-22 [email protected] Reland Add UI Benchmarks (#143542) (flutter/flutter#143799)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
3053b6c Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
400d53e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernaferrari bernaferrari bernaferrari approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@piedcipher @bernaferrari @goderbauer