Skip to content

Ignore implementation_imports in non-lib files #143560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srawlins wants to merge 1 commit into from
Closed

Ignore implementation_imports in non-lib files #143560

srawlins wants to merge 1 commit into from

Conversation

@srawlins
Copy link
Contributor

@srawlins srawlins commented Feb 16, 2024 •
edited
Loading

Work towards dart-lang/sdk#59384

There are libraries outside a lib/ directory, which violate implementation_imports. This PR ignores all such violations.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. labels Feb 16, 2024
@srawlins
Copy link
Contributor Author

srawlins commented Feb 16, 2024

@goderbauer should these be all accompanied by TODOs or something? Not sure what the policy for violating this rule is, as I imagine it is violated a fair amount.

@goderbauer
Copy link
Member

goderbauer commented Feb 16, 2024

Can we just fix these? I am making an attempt in #143594.

@goderbauer goderbauer mentioned this pull request Feb 16, 2024
Merged
@srawlins srawlins closed this Feb 16, 2024
auto-submit bot pushed a commit that referenced this pull request Feb 16, 2024
@goderbauer
Fix implementation imports outside of lib (#143594)
546bdec 
Work towards https://github.com/dart-lang/linter/issues/4859

There are libraries outside a `lib/` directory, which violate `implementation_imports`.

Supersedes #143560.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srawlins @goderbauer