Reverts "Fix and test SemanticsController.simulatedAccessibilityTrave… #143528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsal (flutter#143386)" (flutter#143523) Reverts flutter#143386 Initiated by: Piinks Reason for reverting: This broke a customer test. Original PR Author: Piinks Reviewed By: {goderbauer} This change reverts the following previous change: Original Description: Fixes flutter#143173 The `start` and `end` parameters of `SemanticsController.simulatedAccessibilityTraversal` were deprecated in flutter#112413, but no tests were added that verified the new API. 😳 This change - fixes a typo in an error message - fixes the new `startNode` and `endNode` not being accounted for in setting the traversal range - adds dart fixes for the deprecations - adds tests for the new API that is meant to replace the deprecated one. - Filed flutter#143405 to follow up on the new API not working in multiple views.
github-actions
bot
added
a: tests
fluttergithubbot
approved these changes
Feb 15, 2024
Jasguerrero
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rsal (#143386)" (#143523)
Reverts #143386
Initiated by: Piinks
Reason for reverting: This broke a customer test.
Original PR Author: Piinks
Reviewed By: {goderbauer}
This change reverts the following previous change: Original Description:
Fixes #143173
The
startandendparameters ofSemanticsController.simulatedAccessibilityTraversalwere deprecated in #112413, but no tests were added that verified the new API. 😳This change
startNodeandendNodenot being accounted for in setting the traversal range