Skip to content

[a11y] Add isEnabled semantics flag to text field #143334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Feb 13, 2024
Merged

[a11y] Add isEnabled semantics flag to text field #143334

auto-submit merged 3 commits into from
Feb 13, 2024

Conversation

@hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented Feb 12, 2024 •
edited
Loading

Add a semantics flag to text field to fix #143337 (in IOS the disabled text field is not read dimmed)

internal: b/322345393

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 12, 2024

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 12, 2024
@hannah-hyj hannah-hyj changed the title Add isEnabled semantics flag to text field Add isEnabled semantics flag to editable text Feb 12, 2024
@hannah-hyj hannah-hyj changed the title Add isEnabled semantics flag to editable text Add isEnabled semantics flag to text field Feb 13, 2024
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels Feb 13, 2024
@github-actions github-actions bot added the a: tests "flutter test", flutter_test, or one of our tests label Feb 13, 2024
@hannah-hyj hannah-hyj changed the title Add isEnabled semantics flag to text field [a11y] Add isEnabled semantics flag to text field Feb 13, 2024
@math1man
Copy link
Contributor

math1man commented Feb 13, 2024

This is a good change, but it won't fix #143337. I tried manually wrapping TextField in a Semantics widget myself and it doesn't solve the issue. There is some bug on the iOS and Web engine side that needs to be fixed.

math1man
math1man reviewed Feb 13, 2024
View reviewed changes
@hannah-hyj
Copy link
Member Author

hannah-hyj commented Feb 13, 2024

I did some manually IOS testing, if a semantics node has flags [isTextField hasEnabledState isReadOnly], it will read dimmed in IOS (as we want). if it has flag [isTextField isReadOnly], it's not read as dimmed.

the text field semantics node should have enabled/disabled semantics flag.

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
@auto-submit auto-submit bot merged commit 14bce28 into flutter:master Feb 13, 2024
@math1man math1man mentioned this pull request Feb 13, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
14bce28 [a11y] Add isEnabled semantics flag to text field (flutter/fl…
64b0cca 
…utter#143334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
14bce28 [a11y] Add isEnabled semantics flag to text field (flutter/fl…
b794d69 
…utter#143334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
14bce28 [a11y] Add isEnabled semantics flag to text field (flutter/fl…
8583e7d 
…utter#143334)
@hannah-hyj
Copy link
Member Author

hannah-hyj commented Feb 14, 2024

Reason for revert: broke g3 tests

@hannah-hyj hannah-hyj added the revert Autorevert PR (with "Reason for revert:" comment) label Feb 14, 2024
auto-submit bot pushed a commit that referenced this pull request Feb 14, 2024
Revert "[a11y] Add isEnabled semantics flag to text field (#143334)"
ed15dcb 
This reverts commit 14bce28.
@auto-submit auto-submit bot mentioned this pull request Feb 14, 2024
Merged
8 tasks
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Feb 14, 2024
auto-submit bot added a commit that referenced this pull request Feb 14, 2024
@auto-submit
Reverts "[a11y] Add isEnabled semantics flag to text field (#143334)" (…
0fac13b 
…#143494)

Reverts #143334

Initiated by: hangyujin

Reason for reverting: broke g3 tests

Original PR Author: hangyujin

Reviewed By: {LongCatIsLooong}

This change reverts the following previous change:
Original Description:
Add a semantics flag to   text field to fix #143337 (in IOS the disabled text field is not read `dimmed`)

internal: b/322345393
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
@engine-flutter-autoroll
14bce28 [a11y] Add isEnabled semantics flag to text field (flutter/fl…
bcb16ca 
…utter#143334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
@engine-flutter-autoroll
14bce28 [a11y] Add isEnabled semantics flag to text field (flutter/fl…
bf4c386 
…utter#143334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
@engine-flutter-autoroll
14bce28 [a11y] Add isEnabled semantics flag to text field (flutter/fl…
d35b4ef 
…utter#143334)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
14bce28 [a11y] Add isEnabled semantics flag to text field (flutter/fl…
7f526ef 
…utter#143334)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
14bce28 [a11y] Add isEnabled semantics flag to text field (flutter/fl…
8358ee2 
…utter#143334)
hannah-hyj added a commit that referenced this pull request Feb 16, 2024
@hannah-hyj
Revert "Reverts "[a11y] Add isEnabled semantics flag to text field (#…
3596f76 
…143334)…"

This reverts commit 0fac13b.
@hannah-hyj hannah-hyj mentioned this pull request Feb 16, 2024
Merged
hannah-hyj added a commit to hannah-hyj/flutter that referenced this pull request Feb 22, 2024
@hannah-hyj
Revert "Reverts "[a11y] Add isEnabled semantics flag to text field (f…
2ff0fd9 
…lutter#143334)…"

This reverts commit 0fac13b.
auto-submit bot pushed a commit that referenced this pull request Feb 27, 2024
@hannah-hyj
Reland [a11y] Add isEnabled semantics flag to text field (#143601)
fdb17ab 
Reland #143334
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
14bce28 [a11y] Add isEnabled semantics flag to text field (flutter/fl…
79a11f5 
…utter#143334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

+1 more reviewer

@math1man math1man math1man left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ios] [web] iOS and web Semantics do not support labeling EditTexts as disabled.

3 participants

@hannah-hyj @math1man @LongCatIsLooong