-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Introduce avatarBoxConstraints & deleteIconBoxConstraints for the chips
#143302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce avatarBoxConstraints & deleteIconBoxConstraints for the chips
#143302
Conversation
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including an example with the new constraints properties woudl be helpful. Using the same example would be fine, and the one used for this PR's description would do the job.
I think the new properties should be reflected in the ChipTheme.
Added theme values and examples. |
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4ca27af to
7aba8b6
Compare
… for the chips (flutter/flutter#143302)
… for the chips (flutter/flutter#143302)
… for the chips (flutter/flutter#143302)
… for the chips (flutter/flutter#143302)
… for the chips (flutter/flutter#143302)
… for the chips (flutter/flutter#143302)
… for the chips (flutter/flutter#143302)
… for the chips (flutter/flutter#143302)
… for the chips (flutter/flutter#143302)
fixes Chip widget's avatar padding changing if label text is more than 1 line
Code sample
expand to view the code sample
Preview
Examples previews
avatarBoxConstraintsdeleteIconBoxConstraintsPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.