Skip to content

Cross-link SliverFixedExtentList/SliverPrototypeExtentList/SliverVariedExtentList #143184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 8, 2024
Merged

Cross-link SliverFixedExtentList/SliverPrototypeExtentList/SliverVariedExtentList #143184

auto-submit merged 1 commit into from
Feb 8, 2024

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Feb 8, 2024

Fixes #141678.

@goderbauer goderbauer requested a review from Piinks February 8, 2024 20:59
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Feb 8, 2024
@Piinks Piinks added the d: api docs Issues with https://api.flutter.dev/ label Feb 8, 2024
Piinks
Piinks approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM-cat

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 8, 2024
@auto-submit auto-submit bot merged commit 8d3c7b6 into flutter:master Feb 8, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
74b1992 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
131e1f7 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
0459336 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
d448c8c 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
1ea9e06 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
82605e4 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
9e7cb16 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
c676d2b 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
a6a37da 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
e88f548 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
8570267 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
6d1d9c0 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
bd2c8c3 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
b9b3298 
…iverVariedExtentList (flutter/flutter#143184)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
fee374b 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
a0a2f13 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
1a80423 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
c18376c 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
c64adce 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
7382519 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
7da9745 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
dc7db6b 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
2ba8977 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
994814c 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
8e57576 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
be4a6d9 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
0697ef6 
…iverVariedExtentList (flutter/flutter#143184)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
03752f5 
…iverVariedExtentList (flutter/flutter#143184)
@goderbauer goderbauer deleted the crosslinkdocs branch March 8, 2024 22:18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
8d3c7b6 Cross-link SliverFixedExtentList/SliverPrototypeExtentList/Sl…
c7183b4 
…iverVariedExtentList (flutter/flutter#143184)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Documentation] Missing breadcrumb from SliverFixedExtentList to SliverVariedExtentList

2 participants

@goderbauer @Piinks