[Re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions #143132
Conversation
… KGP versions" (flutter#143114)" This reverts commit d60643e.
github-actions
bot
added
the
tool
|
Audited all other integration tests, and they have the correct order. |
gmackall
requested review from
bartekpacia,
camsim99,
reidbaker and
vashworth
bartekpacia
left a comment
bartekpacia
left a comment
There was a problem hiding this comment.
RSLGTM (I also approved the now-reverted PR). Happy to see this kind of version enforcement being made:)
| final String dependencyCheckerPluginPath = Paths.get(flutterRoot.absolutePath, | ||
| "packages", "flutter_tools", "gradle", "src", "main", "kotlin", | ||
| "dependency_version_checker.gradle.kts") | ||
| project.apply from: dependencyCheckerPluginPath |
There was a problem hiding this comment.
maybe we could add a TODO or something similar that links to #121541. E.g.
We apply a Gradle plugin because we can't use import statements for backward compatibility reasons. See #121541 for more info.
just an idea
There was a problem hiding this comment.
or link to this comment: #142000 (comment)
(I can image people in the future being confused by this)
There was a problem hiding this comment.
Good idea, added a todo with explanation and link to #121541 (comment)
gmackall
added
the
autosubmit
|
@gmackall This may be causing a failure for the Flutter --> packages roller, like flutter/packages#6100 with failed build https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_build_all_packages%20master/6190/overview for example, with the failure: |
|
Time to revert pull request flutter/flutter/143132 has elapsed. |
auto-submit
bot
removed
the
revert
|
Reason for revert: Broke packages roller |
Thanks, I'll get the legacy test running and see why. |
One think to note here is that invalid token is basically a compile error. Which means we do not have framework tests that cover that line. |
|
That test is passing on the non-legacy version of the exact same test, though. I don't think the issue is that it isn't covered. Or at least, not coverage of that specific line. The coverage is also tied to how old the project is and/or the environment (I'm not certain exactly how legacy the legacy test is) |
… versions (#143341) This is a direct revert of (the revert of (the reland of (the policy pr))): #143132. The only change is: 1. to put a conditional all on one line, because the packages repository has a test that uses an old flutter project to make sure nothing regresses. The old project uses an old gradle version, and the old gradle version bundles an old groovy version, and the old groovy version has a bug where lines that start with `&&` don't always work: https://issues.apache.org/jira/browse/GROOVY-7218 (I enjoy that the revert reason ends up providing another strong justification to go forward with the policy). Also thanks to @reidbaker for pointing out this bug. 2. I also made a slight formatting change to the messages that print when out of the support bounds, which I think looks slightly better. I tested this with on a branch that included a revert of #142008, and was able to recreate the failure and verify that it was resolved by 1).
4 participants
Re land of #142000.
Differences:
to
update: the above is wrong, changed to
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.