[a11y] Fix date picker cannot focus on the edit field #143117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
framework
hannah-hyj
changed the title
Update date_picker.dart Update icon_button.dart form field Update date_picker.dart
This was referenced Feb 10, 2024
hannah-hyj
changed the title
QuncCccccc
approved these changes
Feb 14, 2024
| .merge(datePickerTheme.inputDecorationTheme) | ||
| .copyWith(border: effectiveInputBorder), | ||
| return Semantics( | ||
| container: true, |
Contributor
There was a problem hiding this comment.
nit: for this block of code, might need to correct indentation:)
hannah-hyj
added
the
autosubmit
Contributor
|
A reason for requesting a revert of flutter/flutter/143117 could |
auto-submit
bot
removed
the
revert
Contributor
|
Reason for revert: made the tree red. |
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
This reverts commit 846719e.
8 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Feb 14, 2024
…)" (#143493) Reverts #143117 Initiated by: dnfield Reason for reverting: made the tree red. Original PR Author: hangyujin Reviewed By: {QuncCccccc} This change reverts the following previous change: Original Description: fixes: #143116 fixes: #141992 https://b.corp.google.com/issues/322173632
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 16, 2024
Roll Flutter from a628814 to d7867ca (66 revisions) flutter/flutter@a628814...d7867ca 2024-02-16 [email protected] Roll Packages from ef349be to c56c12d (5 revisions) (flutter/flutter#143581) 2024-02-16 [email protected] Update `MaterialStatesController` docs for calling `setState` in a listener (flutter/flutter#143453) 2024-02-16 [email protected] Update `DataTable` docs for disabled `DataRow` ink well (flutter/flutter#143450) 2024-02-16 [email protected] Roll Flutter Engine from b7103bc8b374 to dd530f1556df (17 revisions) (flutter/flutter#143565) 2024-02-16 [email protected] Manual roll Flutter Engine from b7103bc8b374 to 7de84271eb65 (flutter/flutter#143564) 2024-02-16 [email protected] Manual roll Flutter Engine from d3c71d78f8ef to df0dc1fc06ca (flutter/flutter#143563) 2024-02-16 [email protected] Manual roll Flutter Engine from bc4dd534a0fa to d3c71d78f8ef (flutter/flutter#143561) 2024-02-16 [email protected] Manual roll Flutter Engine from edb2745e9834 to bc4dd534a0fa (flutter/flutter#143559) 2024-02-16 [email protected] Manual roll Flutter Engine from 15a358bbaf71 to edb2745e9834 (flutter/flutter#143555) 2024-02-16 [email protected] [devicelab] retain prior events for flutter gallery. (flutter/flutter#143554) 2024-02-16 [email protected] Reland "Disentangle and align flutter build web --wasm flags (#143517)" (flutter/flutter#143549) 2024-02-16 [email protected] Roll Flutter Engine from 3af336bfb2df to 15a358bbaf71 (1 revision) (flutter/flutter#143428) 2024-02-15 [email protected] Android Gradle file templates: make it easier to convert them to Kotlin DSL in the future (flutter/flutter#142146) 2024-02-15 [email protected] Remove bringup from win arm64 builds. (flutter/flutter#143548) 2024-02-15 [email protected] Fix minor spelling error (flutter/flutter#143541) 2024-02-15 [email protected] [devicelab] migrate new gallery benchmarks to local copy. (flutter/flutter#143545) 2024-02-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.1 to 3.24.3 (flutter/flutter#143546) 2024-02-15 [email protected] [flutter_tool] [dap] Forward Flutter progress events to DAP client (flutter/flutter#142524) 2024-02-15 [email protected] Swap the tasks that have been running fine for a while. (flutter/flutter#143544) 2024-02-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disentangle and align `flutter build web --wasm` flags (#143517)" (flutter/flutter#143547) 2024-02-15 [email protected] Reland simulatedAccessibilityTraversal fix (flutter/flutter#143527) 2024-02-15 [email protected] Disentangle and align `flutter build web --wasm` flags (flutter/flutter#143517) 2024-02-15 [email protected] [devicelab] introduce new old gallery. (flutter/flutter#143486) 2024-02-15 [email protected] Remove certs dependency. (flutter/flutter#143495) 2024-02-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix and test SemanticsController.simulatedAccessibilityTraversal (#143386)" (flutter/flutter#143523) 2024-02-15 [email protected] Roll Packages from a864254 to ef349be (9 revisions) (flutter/flutter#143521) 2024-02-15 [email protected] Modify `plugin_ffi` and `package_ffi` template (flutter/flutter#143376) 2024-02-15 [email protected] Remove certs installation from win_arm builds. (flutter/flutter#143487) 2024-02-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[a11y] Add isEnabled semantics flag to text field (#143334)" (flutter/flutter#143494) 2024-02-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[a11y] Fix date picker cannot focus on the edit field (#143117)" (flutter/flutter#143493) 2024-02-14 [email protected] [a11y] Fix date picker cannot focus on the edit field (flutter/flutter#143117) 2024-02-14 [email protected] cleanup now-irrelevant ignores for `deprecated_member_use` (flutter/flutter#143403) 2024-02-14 [email protected] Fix and test SemanticsController.simulatedAccessibilityTraversal (flutter/flutter#143386) 2024-02-14 [email protected] Disable deprecation warnings for mega_gallery (flutter/flutter#143466) 2024-02-14 [email protected] The initial/selected item on popup menu should always be visible (flutter/flutter#143118) 2024-02-14 [email protected] Roll native_assets_builder to 0.5.0 (flutter/flutter#143472) 2024-02-14 [email protected] InputDecorator M3 test migration step2 (flutter/flutter#143369) 2024-02-14 [email protected] Add more documentation for TextEditingController default constructor (flutter/flutter#143452) 2024-02-14 [email protected] Format all kotlin according to ktlint (flutter/flutter#143390) 2024-02-14 [email protected] Marks Linux_pixel_7pro integration_ui_keyboard_resize to be unflaky (flutter/flutter#143440) 2024-02-14 [email protected] Roll Packages from 9385bbb to a864254 (6 revisions) (flutter/flutter#143454) 2024-02-14 [email protected] [tools] Add column header for emulators information (flutter/flutter#142853) 2024-02-14 [email protected] Use `dart compile wasm` for wasm compilations (flutter/flutter#143298) 2024-02-14 [email protected] [devicelab] retain first frame data in certain integration tests. (flutter/flutter#143419) 2024-02-14 [email protected] Roll Flutter Engine from 0849250a1419 to 3af336bfb2df (2 revisions) (flutter/flutter#143427) 2024-02-14 [email protected] Roll Flutter Engine from 215d55f4f82d to 0849250a1419 (2 revisions) (flutter/flutter#143425) ...
9 tasks
hannah-hyj
added a commit
that referenced
this pull request
Feb 29, 2024
reland #143117 fixes: #143116 fixes: #141992 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #143116
fixes: #141992
https://b.corp.google.com/issues/322173632
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.