Fix inputs and outputs for WebReleaseBundle
#143023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
ditman
approved these changes
Feb 7, 2024
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
The caching mechanism of the Flutter tool is mysterious to me. Maybe @christopherfujino has more insight into it! (RS)LGTM!
| @override | ||
| List<Source> get outputs => buildFiles.map( | ||
| (String file) => Source.pattern('{OUTPUT_DIR}/$file') | ||
| (String file) => Source.pattern('{BUILD_DIR}/$file') |
Member
There was a problem hiding this comment.
Should there be a dart2web test that fails because of this change? are the OUTPUT_DIR and BUILD_DIR significantly different?
Contributor
Author
There was a problem hiding this comment.
I think the current test I added is basically sufficient for this, it ensures that the responsibilities for inputs and outputs in the OUTPUT_DIR and BUILD_DIR are reflected properly by the build system. I tried looking into doing an integration test, but it was difficult to actually build and pretty contrived, because you're essentially digging around and modifying things in the internal .dart_tool/flutter_build directory.
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 8, 2024
Roll Flutter from 8431cae to eb5d0a4 (33 revisions) flutter/flutter@8431cae...eb5d0a4 2024-02-08 [email protected] Roll Packages from e4ea6bf to 29d8cc0 (5 revisions) (flutter/flutter#143161) 2024-02-08 [email protected] Roll Flutter Engine from 6d524588c0f9 to f53fbd8393ce (1 revision) (flutter/flutter#143160) 2024-02-08 [email protected] Roll Flutter Engine from 22e1241e9823 to 6d524588c0f9 (3 revisions) (flutter/flutter#143147) 2024-02-08 [email protected] Roll Flutter Engine from 084bd0b8f5ac to 22e1241e9823 (1 revision) (flutter/flutter#143140) 2024-02-08 [email protected] Roll Flutter Engine from 104804aa374e to 084bd0b8f5ac (1 revision) (flutter/flutter#143139) 2024-02-08 [email protected] Roll Flutter Engine from 45137ea6ba29 to 104804aa374e (1 revision) (flutter/flutter#143138) 2024-02-08 [email protected] Pass along web renderer into debugging options in the test command. (flutter/flutter#143128) 2024-02-08 [email protected] Roll Flutter Engine from 4ea7bd07328b to 45137ea6ba29 (2 revisions) (flutter/flutter#143135) 2024-02-08 [email protected] Roll Flutter Engine from 322a461dc74f to 4ea7bd07328b (2 revisions) (flutter/flutter#143131) 2024-02-07 [email protected] Add a unit test for `NavigationRail` (flutter/flutter#143108) 2024-02-07 [email protected] Roll Flutter Engine from b1ba9f329f76 to 322a461dc74f (2 revisions) (flutter/flutter#143123) 2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Improve build output for all platforms" (flutter/flutter#143125) 2024-02-07 [email protected] Roll Flutter Engine from e4a5acc14b44 to b1ba9f329f76 (2 revisions) (flutter/flutter#143120) 2024-02-07 [email protected] Improve build output for all platforms (flutter/flutter#128236) 2024-02-07 [email protected] Roll Flutter Engine from 19ae46afed69 to e4a5acc14b44 (7 revisions) (flutter/flutter#143112) 2024-02-07 [email protected] Fixed cursor blinking during selection. (flutter/flutter#141380) 2024-02-07 [email protected] Remove Cirrus check for web test concurrency (flutter/flutter#143046) 2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enforce a policy on supported Gradle, Java, AGP, and KGP versions" (flutter/flutter#143114) 2024-02-07 [email protected] Enforce a policy on supported Gradle, Java, AGP, and KGP versions (flutter/flutter#142000) 2024-02-07 [email protected] Fix inputs and outputs for `WebReleaseBundle` (flutter/flutter#143023) 2024-02-07 [email protected] Various improvements to text-editing-related documentation. (flutter/flutter#142561) 2024-02-07 [email protected] Revert "Add `SingleChildScrollView` for `NavigationRail`" (flutter/flutter#143097) 2024-02-07 [email protected] Restore log dumps for gradle OOM crashes, and set a value for `MaxMetaspaceSize` (flutter/flutter#143085) 2024-02-07 [email protected] Move Mac_build_test flutter_gallery__transition_perf_e2e_ios out of staging (flutter/flutter#142987) 2024-02-07 [email protected] Roll Flutter Engine from fafd8e55eb4b to 19ae46afed69 (1 revision) (flutter/flutter#143094) 2024-02-07 [email protected] Add a test for the isAvailableForEnvironment logic (flutter/flutter#142251) 2024-02-07 [email protected] Add the number of mismatched pixels to golden tests output (flutter/flutter#142975) 2024-02-07 [email protected] Add indexInParent to SemanticsNode debug information (flutter/flutter#142826) 2024-02-07 [email protected] Remove unused devicelab task gradle_non_android_plugin_test (flutter/flutter#142742) 2024-02-07 [email protected] Make generate_gradle_lockfiles also write the gradle wrapper file (flutter/flutter#142329) 2024-02-07 [email protected] Roll Flutter Engine from 6807342305e4 to fafd8e55eb4b (1 revision) (flutter/flutter#143086) 2024-02-07 [email protected] Remove redundant `rootDirectoryPath` parameter in `DevFS::update` (flutter/flutter#143034) 2024-02-07 [email protected] Handle transitions to AppLifecycleState.detached in lifecycle state generation (flutter/flutter#142523) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
WebReleaseBundleis responsible for copying over the outputs from the subtargets, so it needs to be reflected in inputs and outputs so that things will be recopied when something changes.