Fix: performance improvement on golden test comparison #142913

krispypen · 2024-02-05T14:19:32Z

During golden test image comparison 2 lists of a different type are compared with the method "identical", so this will never be true. The test image is a _Uint8ArrayView while the master image is an Uint8List. So that results in always a heavy computation to get the difference between the test and the master image.

When you run this test snippet I go from 51 seconds to 14 seconds:

import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  for (int i = 0; i < 100; i++) {
    testWidgets('Small test', (WidgetTester tester) async {
      await tester.pumpWidget(Directionality(textDirection: TextDirection.ltr, child: Text('jo')));
      await expectLater(find.byType(Text), matchesGoldenFile('main.png'));
    });
  }
}

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

flutter-dashboard · 2024-02-05T14:19:36Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Piinks

Hey @krispypen welcome! Thanks for contributing!
I am not sure how we might test this, have you reached out on discord to see if it is exempt?

krispypen · 2024-02-07T21:56:48Z

Oh, not yet, I'll check there @Piinks !

Piinks

Thanks for adding a test @krispypen! This LGTM, I'll need to get another reviewer for a second stamp.

justinmc

LGTM 👍. Good catch! Looks like a great performance improvement.

…er/flutter#142913)

Roll Flutter from eb5d0a4 to a628814 (72 revisions) flutter/flutter@eb5d0a4...a628814 2024-02-13 [email protected] Allow deprecated members from the Dart SDK and Flutter Engine to roll in (flutter/flutter#143347) 2024-02-13 [email protected] [Re-re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions (flutter/flutter#143341) 2024-02-13 [email protected] Roll Packages from 0a69259 to 9385bbb (7 revisions) (flutter/flutter#143366) 2024-02-13 [email protected] Fix `InputDecorator`s `suffix` and `prefix` widgets are tappable when hidden (flutter/flutter#143308) 2024-02-13 [email protected] Pass-Through `inputFormatters` in `DropdownMenu` (flutter/flutter#143250) 2024-02-13 [email protected] Fix `insetPadding` parameter nullability for dialogs (flutter/flutter#143305) 2024-02-12 [email protected] Revert "Migrate integration_test plugin to Gradle Kotlin DSL (#142008)" (flutter/flutter#143329) 2024-02-12 [email protected] Badge class doc typo - missing [ (flutter/flutter#143318) 2024-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 1c3ecee77350 to a19077503a0c (8 revisions) (#143322)" (flutter/flutter#143338) 2024-02-12 [email protected] Roll Flutter Engine from 1c3ecee77350 to a19077503a0c (8 revisions) (flutter/flutter#143322) 2024-02-12 [email protected] [web] Move JS interop to extension types (flutter/flutter#143274) 2024-02-12 [email protected] Add documentation for best practices for `StreamBuilder` like `FutureBuilder` (flutter/flutter#143295) 2024-02-12 [email protected] Roll Flutter Engine from 8806987182a3 to 1c3ecee77350 (1 revision) (flutter/flutter#143315) 2024-02-12 [email protected] Fix dual focus issue in CheckboxListTile, RadioListTile and SwitchListTile (flutter/flutter#143213) 2024-02-12 [email protected] Revert "[Re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions" (flutter/flutter#143314) 2024-02-12 [email protected] Update integration_test iOS FTL README script to remove targeted version (flutter/flutter#143248) 2024-02-12 [email protected] Remove unnecessary 'debugLabel: null'. (flutter/flutter#143253) 2024-02-12 [email protected] Introduce `iconAlignment` for the buttons with icon (flutter/flutter#137348) 2024-02-12 [email protected] Roll Packages from 11152d2 to 0a69259 (4 revisions) (flutter/flutter#143306) 2024-02-12 [email protected] Roll Flutter Engine from 4f119619dfa8 to 8806987182a3 (1 revision) (flutter/flutter#143304) 2024-02-12 [email protected] Roll Flutter Engine from b0753c0e25f8 to 4f119619dfa8 (1 revision) (flutter/flutter#143291) 2024-02-11 [email protected] Roll Flutter Engine from 936495d94cc6 to b0753c0e25f8 (1 revision) (flutter/flutter#143282) 2024-02-11 [email protected] Roll Flutter Engine from b06b3e0d75ad to 936495d94cc6 (1 revision) (flutter/flutter#143280) 2024-02-11 [email protected] Roll Flutter Engine from 1478f4e75dd9 to b06b3e0d75ad (1 revision) (flutter/flutter#143275) 2024-02-10 [email protected] Fix text painter longest line resizing logic for `TextWidthBasis.longestLine` (flutter/flutter#143024) 2024-02-10 [email protected] Roll Flutter Engine from e6ceb3504f50 to 1478f4e75dd9 (1 revision) (flutter/flutter#143273) 2024-02-10 [email protected] Move Windows arm64 tests to bringup true (flutter/flutter#143272) 2024-02-10 [email protected] Roll Flutter Engine from 3c5149ccde38 to e6ceb3504f50 (1 revision) (flutter/flutter#143267) 2024-02-10 [email protected] Roll Flutter Engine from c587bd69985f to 3c5149ccde38 (2 revisions) (flutter/flutter#143266) 2024-02-10 [email protected] Roll Flutter Engine from e08b6c899c42 to c587bd69985f (1 revision) (flutter/flutter#143265) 2024-02-10 [email protected] Roll Flutter Engine from 1b8f23bbd099 to e08b6c899c42 (2 revisions) (flutter/flutter#143264) 2024-02-10 [email protected] Roll Flutter Engine from 41daa5b913b9 to 1b8f23bbd099 (2 revisions) (flutter/flutter#143261) 2024-02-10 [email protected] Roll Flutter Engine from f969c52f133a to 41daa5b913b9 (1 revision) (flutter/flutter#143258) 2024-02-10 [email protected] Roll Flutter Engine from 6a3b0216ff5b to f969c52f133a (3 revisions) (flutter/flutter#143256) 2024-02-09 [email protected] Roll Flutter Engine from 8c521eb24171 to 6a3b0216ff5b (4 revisions) (flutter/flutter#143251) 2024-02-09 [email protected] Upgrade leak_tracker. (flutter/flutter#143236) 2024-02-09 [email protected] Fix: performance improvement on golden test comparison (flutter/flutter#142913) 2024-02-09 [email protected] Implementing `switch` expressions in `lib/src/material/` (flutter/flutter#142793) 2024-02-09 [email protected] Add position data to `OnDragEnd` callback (flutter/flutter#140378) 2024-02-09 [email protected] Roll Flutter Engine from 1232d598f7c4 to 8c521eb24171 (2 revisions) (flutter/flutter#143237) 2024-02-09 [email protected] Roll Flutter Engine from 7a5390c6b3bd to 1232d598f7c4 (1 revision) (flutter/flutter#143235) 2024-02-09 [email protected] Set plugin template minimum iOS version to 12.0 (flutter/flutter#143167) 2024-02-09 [email protected] Roll Flutter Engine from 7a241130fcf8 to 7a5390c6b3bd (1 revision) (flutter/flutter#143231) 2024-02-09 [email protected] Migrate integration_test plugin to Gradle Kotlin DSL (flutter/flutter#142008) 2024-02-09 [email protected] Roll Flutter Engine from dcac9863a1fc to 7a241130fcf8 (1 revision) (flutter/flutter#143222) 2024-02-09 [email protected] Roll Flutter Engine from 1508b11bf791 to dcac9863a1fc (1 revision) (flutter/flutter#143220) ...

…er/flutter#142913)

Fix: performance improvement on golden tests

197e3ec

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Feb 5, 2024

goderbauer requested a review from Piinks February 6, 2024 23:17

Piinks reviewed Feb 7, 2024

View reviewed changes

adding a test

888bc7a

krispypen requested a review from Piinks February 8, 2024 10:27

Piinks approved these changes Feb 9, 2024

View reviewed changes

justinmc approved these changes Feb 9, 2024

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 9, 2024

auto-submit bot merged commit 2f117c5 into flutter:master Feb 9, 2024

engine-flutter-autoroll mentioned this pull request Feb 10, 2024

Manual roll Flutter from eb5d0a434ef1 to ee8d3f5e0c21 (41 revisions) flutter/packages#6087

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

54dba38

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 10, 2024

Roll Flutter from eb5d0a434ef1 to 581ec63df47f (44 revisions) flutter/packages#6089

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

73e60e1

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 10, 2024

Roll Flutter from eb5d0a434ef1 to 581ec63df47f (44 revisions) flutter/packages#6090

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

d933606

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 11, 2024

Roll Flutter from eb5d0a434ef1 to dbb3c16aad6f (51 revisions) flutter/packages#6091

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

5fd83ad

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 11, 2024

Roll Flutter from eb5d0a434ef1 to dbb3c16aad6f (51 revisions) flutter/packages#6092

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

302f23c

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 12, 2024

Roll Flutter from eb5d0a434ef1 to 75784a20c925 (53 revisions) flutter/packages#6099

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

443c533

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 12, 2024

Roll Flutter from eb5d0a434ef1 to 82668f168897 (54 revisions) flutter/packages#6100

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

fe72d84

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 12, 2024

Roll Flutter from eb5d0a434ef1 to 10442399fbeb (55 revisions) flutter/packages#6101

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

b6f5ced

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 12, 2024

Roll Flutter from eb5d0a434ef1 to 5a649aa8abfc (56 revisions) flutter/packages#6102

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

ccd555b

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 12, 2024

Roll Flutter from eb5d0a434ef1 to 1d25b0c70024 (57 revisions) flutter/packages#6103

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

5cb6e49

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 12, 2024

Roll Flutter from eb5d0a434ef1 to 49f620d8ea98 (59 revisions) flutter/packages#6104

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

50a2e4f

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 12, 2024

Roll Flutter from eb5d0a434ef1 to 52f923c36084 (61 revisions) flutter/packages#6105

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

60d0041

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Roll Flutter from eb5d0a434ef1 to 1f8d110b8f3a (69 revisions) flutter/packages#6113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

8173a9a

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Roll Flutter from eb5d0a434ef1 to 634fcc716509 (70 revisions) flutter/packages#6114

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

48df554

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Roll Flutter from eb5d0a434ef1 to 8ba086a2777c (71 revisions) flutter/packages#6115

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

80831ef

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Roll Flutter from eb5d0a434ef1 to 8ba086a2777c (71 revisions) flutter/packages#6117

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

f48203f

…er/flutter#142913)

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Roll Flutter from eb5d0a434ef1 to a628814ebd25 (72 revisions) flutter/packages#6118

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

33bd9a2

…er/flutter#142913)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

7eab398

…er/flutter#142913)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

7c93823

…er/flutter#142913)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

6010c13

…er/flutter#142913)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

2f117c5 Fix: performance improvement on golden test comparison (flutt…

28834b1

…er/flutter#142913)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: performance improvement on golden test comparison #142913

Fix: performance improvement on golden test comparison #142913

Uh oh!

krispypen commented Feb 5, 2024 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Feb 5, 2024

Uh oh!

Piinks left a comment

Uh oh!

krispypen commented Feb 7, 2024

Uh oh!

Piinks left a comment

Uh oh!

justinmc left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix: performance improvement on golden test comparison #142913

Fix: performance improvement on golden test comparison #142913

Uh oh!

Conversation

krispypen commented Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Feb 5, 2024

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

krispypen commented Feb 7, 2024

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

krispypen commented Feb 5, 2024 •

edited

Loading