Add SegmentedButton expand feature #142804

AcarFurkan · 2024-02-02T14:31:43Z

The expandedInsets property enhancement for the SegmentedButton widget introduces flexibility in button layout design within Flutter applications. When expandedInsets is not null, this property allows the SegmentedButton to expand, filling the available horizontal space of its parent container and also have the specified insets, thus ensuring a uniform distribution of segment widths across the button. Conversely, with expandedInsets is null, the widget sizes itself based on the intrinsic sizes of its segments, preserving the natural width of each segment. This addition enhances the adaptability of the SegmentedButton to various UI designs, enabling developers to achieve both expansive and compact button layouts seamlessly.

Setting expandedInsets = null

Setting expandedInsets = EdgeInsets.zero

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

fix flutter#139486 The isExpanded property enhancement for the SegmentedButton widget introduces flexibility in button layout design within Flutter applications. When set to true, this property allows the SegmentedButton to expand, filling the available horizontal space of its parent container, thus ensuring a uniform distribution of segment widths across the button. Conversely, with isExpanded set to false, the widget sizes itself based on the intrinsic sizes of its segments, preserving the natural width of each segment. This addition enhances the adaptability of the SegmentedButton to various UI designs, enabling developers to achieve both expansive and compact button layouts seamlessly.

AcarFurkan · 2024-02-02T18:07:28Z

@HansMuller Hi, can you check when you get free?

AcarFurkan · 2024-02-09T10:12:56Z

@goderbauer hi, do you have any feedback?

AcarFurkan · 2024-02-23T15:15:31Z

@HansMuller hi, do you have any feedback? What should l do?

packages/flutter/lib/src/material/segmented_button.dart

packages/flutter/test/material/segmented_button_test.dart

goderbauer

LGTM

QuncCccccc · 2024-03-18T20:13:31Z

packages/flutter/lib/src/material/segmented_button.dart

+  /// If false (default), the button's size is based on the intrinsic
+  /// sizes of its segments, maintaining their natural width. Ideal for
+  /// maintaining consistent segment sizes regardless of the container size.
+  final bool isExpanded;


LGTM! Thanks a lot for the contribution!

If you want, I think we can also make it a little more complicated by changing it to final EdgeInsets? expandedInsets. So when it is EdgeInsets.zero, the segmented button will expand to fill its parent size and if we set a specific edgeInsets for it, the button can have the specified value of space around:) And the default is just null to show its original behavior.

ah it is very logical. l sent a draft can you check. I'm not sure I understand correctly

QuncCccccc · 2024-03-18T20:25:08Z

Oh it seems the second unit test is failed:

AcarFurkan · 2024-03-18T23:31:48Z

Oh it seems the second unit test is failed:

@QuncCccccc thanks for quick reply. The tests are running successfully in my locale. I didn't fully understand.

QuncCccccc

Thanks a lot for the improvement!! That looks great! Just left two more comments, and then all good to go:)

packages/flutter/lib/src/material/segmented_button.dart

QuncCccccc

LGTM:)! Thanks for the contribution!

packages/flutter/lib/src/material/segmented_button.dart

Co-authored-by: Qun Cheng <[email protected]>

AcarFurkan · 2024-03-19T19:36:35Z

Thanks for help

QuncCccccc · 2024-03-25T19:55:07Z

It looks like the failure in linux web_tests_4 is because of #143932 (comment)
An issue is filed: #145527

To fix this test, we can do the same thing as the commit: c8a769f

QuncCccccc

LGTM

AcarFurkan · 2024-04-03T13:47:45Z

LGTM

thanks for help :) should l do something else

QuncCccccc · 2024-04-03T16:17:59Z

LGTM

thanks for help :) should l do something else

Nope, just merged it:) Thanks for your contribution!

Roll Flutter from a418568 to e868e2b (34 revisions) flutter/flutter@a418568...e868e2b 2024-04-03 [email protected] Add SegmentedButton expand feature (flutter/flutter#142804) 2024-04-03 [email protected] Roll Flutter Engine from e36b9b10c36f to 56fa2c33a5f7 (1 revision) (flutter/flutter#146205) 2024-04-03 [email protected] Roll Packages from 83f3842 to 0e848fa (3 revisions) (flutter/flutter#146201) 2024-04-03 [email protected] Enhance ColorScheme.fromSeed with a new `variant` parameter (flutter/flutter#144805) 2024-04-03 [email protected] Roll Flutter Engine from 0280de5be276 to e36b9b10c36f (1 revision) (flutter/flutter#146200) 2024-04-03 [email protected] Fix typos in bottom_sheet.dart (flutter/flutter#146188) 2024-04-03 [email protected] Roll Flutter Engine from 979030d81f8d to 0280de5be276 (2 revisions) (flutter/flutter#146199) 2024-04-03 [email protected] Roll Flutter Engine from bef3bbe3f74e to 979030d81f8d (1 revision) (flutter/flutter#146186) 2024-04-03 [email protected] Roll Flutter Engine from 5fc83bc24b2e to bef3bbe3f74e (1 revision) (flutter/flutter#146183) 2024-04-03 [email protected] Roll Flutter Engine from 0da1b2eb370a to 5fc83bc24b2e (1 revision) (flutter/flutter#146180) 2024-04-03 [email protected] Avoid calling `TextPainter.plainText` for simple static text (flutter/flutter#146084) 2024-04-03 [email protected] Roll Flutter Engine from e603f89844a9 to 0da1b2eb370a (2 revisions) (flutter/flutter#146179) 2024-04-03 [email protected] Roll Flutter Engine from ef60a95d78c1 to e603f89844a9 (3 revisions) (flutter/flutter#146177) 2024-04-03 [email protected] Fix chip baseline implementation (flutter/flutter#146162) 2024-04-03 [email protected] Roll Flutter Engine from bb4ec2d7eb39 to ef60a95d78c1 (1 revision) (flutter/flutter#146176) 2024-04-03 [email protected] Add tests for material_state_mouse_cursor.0.dart API example. (flutter/flutter#145987) 2024-04-03 [email protected] Update material_color_utilities package version to latest 0.11.1 (flutter/flutter#145959) 2024-04-03 [email protected] Roll Flutter Engine from 5f6dec8bd877 to bb4ec2d7eb39 (4 revisions) (flutter/flutter#146169) 2024-04-03 [email protected] Roll Flutter Engine from 5dbcfdc2a456 to 5f6dec8bd877 (1 revision) (flutter/flutter#146163) 2024-04-02 [email protected] Dispose FocusNode in tests. (flutter/flutter#146161) 2024-04-02 [email protected] Add `none` language strings to code blocks. (flutter/flutter#146154) 2024-04-02 [email protected] Refactor docs (flutter/flutter#145998) 2024-04-02 [email protected] Roll Flutter Engine from c60b00a20fc3 to 5dbcfdc2a456 (3 revisions) (flutter/flutter#146159) 2024-04-02 [email protected] Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller__timeline_summary to be unflaky (flutter/flutter#140038) 2024-04-02 [email protected] Roll Flutter Engine from 5bf8b94505a4 to c60b00a20fc3 (2 revisions) (flutter/flutter#146157) 2024-04-02 [email protected] Refactor analyze (flutter/flutter#146138) 2024-04-02 [email protected] Implement SelectionArea triple click gestures (flutter/flutter#144563) 2024-04-02 [email protected] Roll Flutter Engine from 6883f7313da0 to 5bf8b94505a4 (2 revisions) (flutter/flutter#146152) 2024-04-02 [email protected] Fix border color is wrong for a focused and hovered TextField (flutter/flutter#146127) 2024-04-02 [email protected] Sync lints and enable `annotate_redeclares` (flutter/flutter#146144) 2024-04-02 [email protected] Implements `RenderBox.computeDryBaseline` for material render boxes (flutter/flutter#146027) 2024-04-02 [email protected] Roll Flutter Engine from 523fc953ebc8 to 6883f7313da0 (2 revisions) (flutter/flutter#146140) 2024-04-02 [email protected] Fix `MenuItemButton` overflow (flutter/flutter#143932) 2024-04-02 [email protected] Roll Packages from d5aff19 to 83f3842 (4 revisions) (flutter/flutter#146134) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 2, 2024

Merge branch 'master' into master

6efab1b

HansMuller requested a review from goderbauer February 2, 2024 22:36

Merge branch 'master' into master

efdadb3

goderbauer reviewed Mar 15, 2024

View reviewed changes

packages/flutter/lib/src/material/segmented_button.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/segmented_button.dart Outdated Show resolved Hide resolved

fix comment and expanded logic

432bb7c

AcarFurkan requested a review from goderbauer March 18, 2024 10:47

goderbauer reviewed Mar 18, 2024

View reviewed changes

packages/flutter/lib/src/material/segmented_button.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/segmented_button_test.dart Outdated Show resolved Hide resolved

AcarFurkan added 2 commits March 18, 2024 21:09

fix indent

47fa9a6

isExpanded logic moved to condition block

ea6a812

AcarFurkan requested a review from goderbauer March 18, 2024 18:23

Merge branch 'master' into master

6b585fd

goderbauer approved these changes Mar 18, 2024

View reviewed changes

goderbauer requested a review from QuncCccccc March 18, 2024 19:37

QuncCccccc approved these changes Mar 18, 2024

View reviewed changes

Merge branch 'master' into master

1729a8a

AcarFurkan force-pushed the master branch from 22d009e to 1729a8a Compare March 18, 2024 23:27

Merge branch 'master' into master

8f3bef9

AcarFurkan added 2 commits March 19, 2024 14:12

set screen size for unit test

939c502

Draft: convert isExpanded to expandedInsets

deeff9d

AcarFurkan requested a review from QuncCccccc March 19, 2024 11:54

QuncCccccc mentioned this pull request Mar 19, 2024

Fix MenuItemButton overflow #143932

Merged

9 tasks

QuncCccccc reviewed Mar 19, 2024

View reviewed changes

packages/flutter/lib/src/material/segmented_button.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/segmented_button.dart Outdated Show resolved Hide resolved

AcarFurkan added 2 commits March 19, 2024 22:20

update documentation and add isExpanded field

3106914

Update segmented_button_test.dart

0afdc71

AcarFurkan requested a review from QuncCccccc March 19, 2024 19:28

QuncCccccc approved these changes Mar 19, 2024

View reviewed changes

packages/flutter/lib/src/material/segmented_button.dart Outdated Show resolved Hide resolved

Update packages/flutter/lib/src/material/segmented_button.dart

e36d867

Co-authored-by: Qun Cheng <[email protected]>

TahaTesser mentioned this pull request Mar 20, 2024

Use a separate TextPainter for intrinsics calculation in RenderEditable and RenderParagraph #144577

Merged

9 tasks

Merge branch 'master' into master

dc323c1

AcarFurkan added 2 commits March 30, 2024 01:04

Merge branch 'flutter:master' into master

78fd40a

fix: dart analyzer

9bb03cc

AcarFurkan requested a review from QuncCccccc March 29, 2024 23:18

Merge branch 'master' into master

3a0fb45

QuncCccccc approved these changes Apr 2, 2024

View reviewed changes

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2024

auto-submit bot merged commit e868e2b into flutter:master Apr 3, 2024

engine-flutter-autoroll mentioned this pull request Apr 3, 2024

Roll Flutter from a418568a6498 to e868e2b3834f (34 revisions) flutter/packages#6455

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2024

e868e2b Add SegmentedButton expand feature (flutter/flutter#142804)

6acd32a

HansMuller mentioned this pull request Apr 5, 2024

Flutter Framework Team: Notable Commits #121415

Closed

Add SegmentedButton expand feature #142804

Add SegmentedButton expand feature #142804

Uh oh!

Conversation

AcarFurkan commented Feb 2, 2024 • edited by QuncCccccc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Setting expandedInsets = null

Setting expandedInsets = EdgeInsets.zero

Pre-launch Checklist

Uh oh!

AcarFurkan commented Feb 2, 2024

Uh oh!

AcarFurkan commented Feb 9, 2024

Uh oh!

AcarFurkan commented Feb 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

AcarFurkan Mar 19, 2024

Choose a reason for hiding this comment

Uh oh!

QuncCccccc commented Mar 18, 2024

Uh oh!

AcarFurkan commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AcarFurkan commented Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QuncCccccc commented Mar 25, 2024

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

AcarFurkan commented Apr 3, 2024

Uh oh!

QuncCccccc commented Apr 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AcarFurkan commented Feb 2, 2024 •

edited by QuncCccccc

Loading

AcarFurkan commented Mar 18, 2024 •

edited

Loading

AcarFurkan commented Mar 19, 2024 •

edited

Loading