Implementing `switch` expressions in `lib/src/material/` #142793

nate-thegrate · 2024-02-02T07:07:14Z

This PR is the 6ᵗʰ step in the journey to solve issue #136139 and make the entire Flutter repo more readable.

(previous pull requests: #139048, #139882, #141591, #142279, #142634)

The current focus is on packages/flutter/lib/src/material/. The previous 2 PRs covered files in this directory starting with letters a-m; this one takes care of everything else.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-02-02T07:07:17Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard · 2024-02-02T07:18:02Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

…er into switch-expressions-6

goderbauer

LGTM

packages/flutter/lib/src/material/radio_list_tile.dart

packages/flutter/lib/src/material/time_picker.dart

Piinks

Also LGTM with the outstanding nits. :)

Piinks · 2024-02-09T21:04:28Z

with the outstanding nits.

Which are now resolved. Thanks for contributing!

…tter/flutter#142793)

This PR is the 7áµ�Ê° step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793) This pull request covers everything in `packages/flutter/lib/src/widgets/`. Most of it should be really straightforward, but there was some refactoring in the `getOffsetToReveal()` function in `two_dimensional_viewport.dart`. I'll add some comments to describe those changes.

…tter/flutter#142793)

Roll Flutter from eb5d0a4 to a628814 (72 revisions) flutter/flutter@eb5d0a4...a628814 2024-02-13 [email protected] Allow deprecated members from the Dart SDK and Flutter Engine to roll in (flutter/flutter#143347) 2024-02-13 [email protected] [Re-re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions (flutter/flutter#143341) 2024-02-13 [email protected] Roll Packages from 0a69259 to 9385bbb (7 revisions) (flutter/flutter#143366) 2024-02-13 [email protected] Fix `InputDecorator`s `suffix` and `prefix` widgets are tappable when hidden (flutter/flutter#143308) 2024-02-13 [email protected] Pass-Through `inputFormatters` in `DropdownMenu` (flutter/flutter#143250) 2024-02-13 [email protected] Fix `insetPadding` parameter nullability for dialogs (flutter/flutter#143305) 2024-02-12 [email protected] Revert "Migrate integration_test plugin to Gradle Kotlin DSL (#142008)" (flutter/flutter#143329) 2024-02-12 [email protected] Badge class doc typo - missing [ (flutter/flutter#143318) 2024-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 1c3ecee77350 to a19077503a0c (8 revisions) (#143322)" (flutter/flutter#143338) 2024-02-12 [email protected] Roll Flutter Engine from 1c3ecee77350 to a19077503a0c (8 revisions) (flutter/flutter#143322) 2024-02-12 [email protected] [web] Move JS interop to extension types (flutter/flutter#143274) 2024-02-12 [email protected] Add documentation for best practices for `StreamBuilder` like `FutureBuilder` (flutter/flutter#143295) 2024-02-12 [email protected] Roll Flutter Engine from 8806987182a3 to 1c3ecee77350 (1 revision) (flutter/flutter#143315) 2024-02-12 [email protected] Fix dual focus issue in CheckboxListTile, RadioListTile and SwitchListTile (flutter/flutter#143213) 2024-02-12 [email protected] Revert "[Re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions" (flutter/flutter#143314) 2024-02-12 [email protected] Update integration_test iOS FTL README script to remove targeted version (flutter/flutter#143248) 2024-02-12 [email protected] Remove unnecessary 'debugLabel: null'. (flutter/flutter#143253) 2024-02-12 [email protected] Introduce `iconAlignment` for the buttons with icon (flutter/flutter#137348) 2024-02-12 [email protected] Roll Packages from 11152d2 to 0a69259 (4 revisions) (flutter/flutter#143306) 2024-02-12 [email protected] Roll Flutter Engine from 4f119619dfa8 to 8806987182a3 (1 revision) (flutter/flutter#143304) 2024-02-12 [email protected] Roll Flutter Engine from b0753c0e25f8 to 4f119619dfa8 (1 revision) (flutter/flutter#143291) 2024-02-11 [email protected] Roll Flutter Engine from 936495d94cc6 to b0753c0e25f8 (1 revision) (flutter/flutter#143282) 2024-02-11 [email protected] Roll Flutter Engine from b06b3e0d75ad to 936495d94cc6 (1 revision) (flutter/flutter#143280) 2024-02-11 [email protected] Roll Flutter Engine from 1478f4e75dd9 to b06b3e0d75ad (1 revision) (flutter/flutter#143275) 2024-02-10 [email protected] Fix text painter longest line resizing logic for `TextWidthBasis.longestLine` (flutter/flutter#143024) 2024-02-10 [email protected] Roll Flutter Engine from e6ceb3504f50 to 1478f4e75dd9 (1 revision) (flutter/flutter#143273) 2024-02-10 [email protected] Move Windows arm64 tests to bringup true (flutter/flutter#143272) 2024-02-10 [email protected] Roll Flutter Engine from 3c5149ccde38 to e6ceb3504f50 (1 revision) (flutter/flutter#143267) 2024-02-10 [email protected] Roll Flutter Engine from c587bd69985f to 3c5149ccde38 (2 revisions) (flutter/flutter#143266) 2024-02-10 [email protected] Roll Flutter Engine from e08b6c899c42 to c587bd69985f (1 revision) (flutter/flutter#143265) 2024-02-10 [email protected] Roll Flutter Engine from 1b8f23bbd099 to e08b6c899c42 (2 revisions) (flutter/flutter#143264) 2024-02-10 [email protected] Roll Flutter Engine from 41daa5b913b9 to 1b8f23bbd099 (2 revisions) (flutter/flutter#143261) 2024-02-10 [email protected] Roll Flutter Engine from f969c52f133a to 41daa5b913b9 (1 revision) (flutter/flutter#143258) 2024-02-10 [email protected] Roll Flutter Engine from 6a3b0216ff5b to f969c52f133a (3 revisions) (flutter/flutter#143256) 2024-02-09 [email protected] Roll Flutter Engine from 8c521eb24171 to 6a3b0216ff5b (4 revisions) (flutter/flutter#143251) 2024-02-09 [email protected] Upgrade leak_tracker. (flutter/flutter#143236) 2024-02-09 [email protected] Fix: performance improvement on golden test comparison (flutter/flutter#142913) 2024-02-09 [email protected] Implementing `switch` expressions in `lib/src/material/` (flutter/flutter#142793) 2024-02-09 [email protected] Add position data to `OnDragEnd` callback (flutter/flutter#140378) 2024-02-09 [email protected] Roll Flutter Engine from 1232d598f7c4 to 8c521eb24171 (2 revisions) (flutter/flutter#143237) 2024-02-09 [email protected] Roll Flutter Engine from 7a5390c6b3bd to 1232d598f7c4 (1 revision) (flutter/flutter#143235) 2024-02-09 [email protected] Set plugin template minimum iOS version to 12.0 (flutter/flutter#143167) 2024-02-09 [email protected] Roll Flutter Engine from 7a241130fcf8 to 7a5390c6b3bd (1 revision) (flutter/flutter#143231) 2024-02-09 [email protected] Migrate integration_test plugin to Gradle Kotlin DSL (flutter/flutter#142008) 2024-02-09 [email protected] Roll Flutter Engine from dcac9863a1fc to 7a241130fcf8 (1 revision) (flutter/flutter#143222) 2024-02-09 [email protected] Roll Flutter Engine from 1508b11bf791 to dcac9863a1fc (1 revision) (flutter/flutter#143220) ...

…143496) This PR is the 8áµ�Ê° step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293) I did a pass through all of `packages/flutter/lib/src/` and found a whole bunch of `switch` statements to improve: most of them were really simple, but many involved some thorough refactoring. This pull request is just the complicated stuff. ð�� I'll make comments to describe the changes, and then in the future there will be another PR (and it'll be much easier to review than this one).

…143634) This PR is the 9áµ�Ê° step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293, #143496) I did a pass through all of `packages/flutter/lib/src/` and found an abundance of `switch` statements to improve. Whereas #143496 focused on in-depth refactoring, this PR is full of simple, straightforward changes. (I ended up making some more complicated changes in `rendering/` and will file those separately after this PR is done.)

This pull request is step 12 in the journey to make this entire repository more readable. (previous PRs: #139048, #139882, #141591, #142279, #142634, #142793, #143293, #143496, #143634, #143812, #144580) We're getting close to the end! ð��

…tter/flutter#142793)

implement switch expressions

0982ca1

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 2, 2024

nate-thegrate marked this pull request as draft February 2, 2024 07:17

nate-thegrate added 6 commits February 2, 2024 09:33

Merge branch 'master' into switch-expressions-6

eb5e202

Merge branch 'master' into switch-expressions-6

fb781f3

Merge branch 'master' into switch-expressions-6

99b3813

fix newPosition declaration

9904b8a

Merge branch 'switch-expressions-6' of github.com:nate-thegrate/flutt…

de76fb6

…er into switch-expressions-6

revert s t u file changes

4eeb3e8

github-actions bot removed the a: text input Entering text in a text field or keyboard related problems label Feb 3, 2024

nate-thegrate added 2 commits February 3, 2024 14:14

fix variable declaration

11bd30b

re-implement s t u file changes

b8c0732

github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Feb 3, 2024

nate-thegrate marked this pull request as ready for review February 3, 2024 23:33

whitespace change

c929d64

goderbauer approved these changes Feb 9, 2024

View reviewed changes

packages/flutter/lib/src/material/radio_list_tile.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/time_picker.dart Outdated Show resolved Hide resolved

goderbauer requested a review from Piinks February 9, 2024 18:37

Piinks approved these changes Feb 9, 2024

View reviewed changes

Apply suggestions from code review

1cc3634

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 9, 2024

auto-submit bot merged commit 1887bc4 into flutter:master Feb 9, 2024

nate-thegrate deleted the switch-expressions-6 branch February 9, 2024 22:13

engine-flutter-autoroll mentioned this pull request Feb 10, 2024

Manual roll Flutter from eb5d0a434ef1 to ee8d3f5e0c21 (41 revisions) flutter/packages#6087

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

a5883da

…tter/flutter#142793)

engine-flutter-autoroll mentioned this pull request Feb 10, 2024

Roll Flutter from eb5d0a434ef1 to 581ec63df47f (44 revisions) flutter/packages#6089

Closed

engine-flutter-autoroll mentioned this pull request Feb 12, 2024

Roll Flutter from eb5d0a434ef1 to 1d25b0c70024 (57 revisions) flutter/packages#6103

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

c7ffd28

…tter/flutter#142793)

engine-flutter-autoroll mentioned this pull request Feb 12, 2024

Roll Flutter from eb5d0a434ef1 to 49f620d8ea98 (59 revisions) flutter/packages#6104

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

f36b491

…tter/flutter#142793)

engine-flutter-autoroll mentioned this pull request Feb 12, 2024

Roll Flutter from eb5d0a434ef1 to 52f923c36084 (61 revisions) flutter/packages#6105

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

cb70049

…tter/flutter#142793)

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Roll Flutter from eb5d0a434ef1 to 1f8d110b8f3a (69 revisions) flutter/packages#6113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

5cfa708

…tter/flutter#142793)

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Roll Flutter from eb5d0a434ef1 to 634fcc716509 (70 revisions) flutter/packages#6114

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

7f3fb3f

…tter/flutter#142793)

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Roll Flutter from eb5d0a434ef1 to 8ba086a2777c (71 revisions) flutter/packages#6115

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

722362a

…tter/flutter#142793)

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Roll Flutter from eb5d0a434ef1 to 8ba086a2777c (71 revisions) flutter/packages#6117

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

93d4e0e

…tter/flutter#142793)

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Roll Flutter from eb5d0a434ef1 to a628814ebd25 (72 revisions) flutter/packages#6118

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

a600264

…tter/flutter#142793)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

b8346d8

…tter/flutter#142793)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

00cb36a

…tter/flutter#142793)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

c49d170

…tter/flutter#142793)

nate-thegrate mentioned this pull request Feb 14, 2024

Implementing switch expressions [refactoring flutter/lib/src/] #143496

Merged

8 tasks

nate-thegrate mentioned this pull request Feb 17, 2024

Implementing switch expressions: everything in flutter/lib/src/ #143634

Merged

8 tasks

nate-thegrate mentioned this pull request Mar 23, 2024

Implementing switch expressions in flutter_tools/ #145632

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

1887bc4 Implementing switch expressions in lib/src/material/ (flu…

2a32bc1

…tter/flutter#142793)

nate-thegrate added the refactor Improving readability/efficiency without behavioral changes label Jul 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implementing `switch` expressions in `lib/src/material/` #142793

Implementing `switch` expressions in `lib/src/material/` #142793

Uh oh!

nate-thegrate commented Feb 2, 2024

Uh oh!

flutter-dashboard bot commented Feb 2, 2024

Uh oh!

flutter-dashboard bot commented Feb 2, 2024

Uh oh!

goderbauer left a comment

Uh oh!

Uh oh!

Uh oh!

Piinks left a comment

Uh oh!

Piinks commented Feb 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Implementing switch expressions in lib/src/material/ #142793

Implementing switch expressions in lib/src/material/ #142793

Uh oh!

Conversation

nate-thegrate commented Feb 2, 2024

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Feb 2, 2024

Uh oh!

flutter-dashboard bot commented Feb 2, 2024

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Feb 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Implementing `switch` expressions in `lib/src/material/` #142793

Implementing `switch` expressions in `lib/src/material/` #142793