-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Really disable shuffling for gen_defaults tests #142721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@zanderso Does Seems there were also some errors in that part https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20framework_tests_misc/75/overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with question above: #142721 (comment)
14de52d to
3063d2b
Compare
|
@vashworth Thanks for spotting that. I've updated the PR to disable shuffling for gen_defaults tests (hopefully) the right way, and also added the tag to widget_tester_test.dart. |
vashworth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this. The test isn't failing. (Well, it fails ones and then is retried to verify the retry logic, what you saw in the log is the expected first failure. Overall the test passes with the seed.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Also disable shuffling for widget_tester_test.dart
3063d2b to
9ee0ed3
Compare
#142716