Skip to content

Add no-shuffle tag to gen_defaults_test.dart #142717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 1, 2024
Merged

Add no-shuffle tag to gen_defaults_test.dart #142717

auto-submit merged 1 commit into from
Feb 1, 2024

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Feb 1, 2024

For #142716

@zanderso zanderso requested a review from andrewkolos February 1, 2024 16:07
vashworth
vashworth approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zanderso zanderso added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels Feb 1, 2024
@auto-submit auto-submit bot merged commit 8a5509e into flutter:master Feb 1, 2024
@zanderso zanderso deleted the no-shuffle branch February 1, 2024 16:39
@goderbauer goderbauer mentioned this pull request Feb 1, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
22c773b 
…#142717)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
d7ebb46 
…#142717)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
537c691 
…#142717)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
6d644e6 
…#142717)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
b5658c9 
…#142717)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
1f11eb3 
…#142717)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
ae0f69b 
…#142717)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
df2717b 
…#142717)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
f13de81 
…#142717)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
a921ef5 
…#142717)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
0907971 
…#142717)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
143dff2 
…#142717)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
d5657bc 
…#142717)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
0c434c8 
…#142717)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
8a5509e Add no-shuffle tag to gen_defaults_test.dart (flutter/flutter…
d8da254 
…#142717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth vashworth approved these changes

@andrewkolos andrewkolos Awaiting requested review from andrewkolos

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @vashworth