Fix: selection handles do not inherit color from local Theme widget
#142476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: text input
Renzo-Olivares
changed the title
Theme widgetTheme widget
github-actions
bot
added
the
f: cupertino
LongCatIsLooong
approved these changes
Jan 29, 2024
Renzo-Olivares
force-pushed
the
handle-color-fix
branch
from
be7e315 to
a123ef3
Compare
Renzo-Olivares
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 1, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 1, 2024
Manual roll requested by [email protected] flutter/flutter@75a2e5b...c65ab4d 2024-01-31 [email protected] Roll Flutter Engine from 2d2d88068a23 to 8e7df85f7d11 (2 revisions) (flutter/flutter#142583) 2024-01-31 [email protected] Add `DropdownMenu.focusNode` (flutter/flutter#142516) 2024-01-31 [email protected] Marks Windows_android native_assets_android to be unflaky (flutter/flutter#140042) 2024-01-31 [email protected] Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary to be unflaky (flutter/flutter#140039) 2024-01-31 [email protected] Marks Linux_android native_assets_android to be unflaky (flutter/flutter#140040) 2024-01-31 [email protected] Marks Mac_android native_assets_android to be unflaky (flutter/flutter#140041) 2024-01-31 [email protected] Marks Mac flavors_test_macos to be unflaky (flutter/flutter#140647) 2024-01-31 [email protected] Roll Flutter Engine from 588f06b02664 to 2d2d88068a23 (1 revision) (flutter/flutter#142569) 2024-01-31 [email protected] Roll Flutter Engine from e6e1d6b3d035 to 588f06b02664 (1 revision) (flutter/flutter#142566) 2024-01-31 [email protected] M3 - Fix Chip icon and label colors (flutter/flutter#140573) 2024-01-31 [email protected] Roll Flutter Engine from d20ed240ace9 to e6e1d6b3d035 (3 revisions) (flutter/flutter#142564) 2024-01-30 [email protected] Be less verbose in CI for customer_testing, and revert old timeout hack (flutter/flutter#139611) 2024-01-30 [email protected] use PDI to end the isolated scope for RLI (flutter/flutter#141345) 2024-01-30 [email protected] Style correctness improvements for toStrings and related fixes (flutter/flutter#142485) 2024-01-30 [email protected] Roll Flutter Engine from 500ae6c4d947 to d20ed240ace9 (1 revision) (flutter/flutter#142554) 2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.5 to 3.1.6 (flutter/flutter#142553) 2024-01-30 [email protected] Roll Flutter Engine from cd12316a0883 to 500ae6c4d947 (1 revision) (flutter/flutter#142551) 2024-01-30 [email protected] Roll Flutter Engine from 0e4342c5a1f2 to cd12316a0883 (6 revisions) (flutter/flutter#142548) 2024-01-30 [email protected] Roll Flutter Engine from 438e9b4d7d4e to 0e4342c5a1f2 (11 revisions) (flutter/flutter#142543) 2024-01-30 [email protected] Fix: selection handles do not inherit color from local `Theme` widget (flutter/flutter#142476) 2024-01-30 [email protected] Marks Windows_arm64 plugin_test_windows to be unflaky (flutter/flutter#137675) 2024-01-30 [email protected] Revert "Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions)" (flutter/flutter#142533) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses
CapturedThemes to capture the themes from the context the selection handles were built in and wraps the handles with them so they can correctly inheritThemes from localThemewidgets.CapturedThemes only capturesInheritedThemes, so this change also makes_InheritedCupertinoThemeanInheritedTheme. This is so we can capture themes declared under aCupertinoTheme, for exampleprimaryColoris used as the selection handle color.Fixes #74890
Pre-launch Checklist
///).