Skip to content

Guard all calls writeln calls on Process::stdin #142356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrewkolos wants to merge 14 commits into from
Closed

Guard all calls writeln calls on Process::stdin #142356

andrewkolos wants to merge 14 commits into from

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Jan 27, 2024

Resolves #137184

Succeeds #140996

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 27, 2024
@andrewkolos andrewkolos mentioned this pull request Jan 27, 2024
Closed
@andrewkolos
Copy link
Contributor Author

andrewkolos commented Feb 5, 2024

@christopherfujino has graciously volunteered to take this back over, as I have struggled to implement a working solution in this PR. Closing.

@andrewkolos andrewkolos closed this Feb 5, 2024
@andrewkolos andrewkolos deleted the the-stdin-plumber branch April 29, 2024 18:18
@andrewkolos andrewkolos mentioned this pull request Jul 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flutter_tools] Writing to the stdin sink of any process risks a crash that can have no useful stack trace

2 participants

@andrewkolos @christopherfujino