Skip to content

[CP] Update tests to Xcode 15 #142320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jan 29, 2024
Merged

[CP] Update tests to Xcode 15 #142320

auto-submit merged 1 commit into from
Jan 29, 2024

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Jan 26, 2024

Tests have been running successfully on Mac-13 with Xcode 15 since 01/17/24. This is needed so we can eventually upgrade physical devices to iOS 17.

Original PR: #141706

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth changed the title Update tests to Xcode 15 [CP] Update tests to Xcode 15 Jan 26, 2024
@vashworth vashworth mentioned this pull request Jan 26, 2024
Closed
@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2024
@auto-submit auto-submit bot merged commit 838b885 into flutter:flutter-3.19-candidate.1 Jan 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
838b885aa [CP] Update tests to Xcode 15 (flutter/flutter#142320)
cfffa11
danielatego pushed a commit to danielatego/flutter that referenced this pull request Jun 6, 2024
@vashworth @danielatego
[CP] Update tests to Xcode 15 (flutter#142320)
88d2a1f 
Tests have been running successfully on Mac-13 with Xcode 15 since 01/17/24. This is needed so we can eventually upgrade physical devices to iOS 17.

Original PR: flutter#141706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vashworth @jmagman @CaseyHillers