Skip to content

Remove textScaleFactor references from flutter/flutter #142271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jan 26, 2024
Merged

Remove textScaleFactor references from flutter/flutter #142271

auto-submit merged 2 commits into from
Jan 26, 2024

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Jan 25, 2024 •
edited
Loading

These should the the last remaining MediaQueryData.textScaleFactor and TextScaler.textScaleFactor references.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jan 25, 2024
@LongCatIsLooong LongCatIsLooong force-pushed the remove-textScaleFactor-references branch from 53c6851 to f578e87 Compare January 25, 2024 23:55
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review January 26, 2024 00:00
QuncCccccc
QuncCccccc approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 26, 2024
@auto-submit auto-submit bot merged commit 505845c into flutter:master Jan 26, 2024
@LongCatIsLooong LongCatIsLooong deleted the remove-textScaleFactor-references branch January 26, 2024 19:13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2024
@engine-flutter-autoroll
505845c Remove textScaleFactor references from flutter/flutter (flutt…
fb1fced 
…er/flutter#142271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2024
@engine-flutter-autoroll
505845c Remove textScaleFactor references from flutter/flutter (flutt…
faea539 
…er/flutter#142271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2024
@engine-flutter-autoroll
505845c Remove textScaleFactor references from flutter/flutter (flutt…
e7ff4b9 
…er/flutter#142271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2024
@engine-flutter-autoroll
505845c Remove textScaleFactor references from flutter/flutter (flutt…
654cd4b 
…er/flutter#142271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2024
@engine-flutter-autoroll
505845c Remove textScaleFactor references from flutter/flutter (flutt…
ce812c9 
…er/flutter#142271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2024
@engine-flutter-autoroll
505845c Remove textScaleFactor references from flutter/flutter (flutt…
f46b9d6 
…er/flutter#142271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2024
@engine-flutter-autoroll
505845c Remove textScaleFactor references from flutter/flutter (flutt…
6800394 
…er/flutter#142271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2024
@engine-flutter-autoroll
505845c Remove textScaleFactor references from flutter/flutter (flutt…
2ad941b 
…er/flutter#142271)
@albemala
Copy link

albemala commented Jan 29, 2024

@LongCatIsLooong I believe there is a typo in the name containerScaingFactor. Or was it fixed in a later PR?

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2024
@engine-flutter-autoroll
505845c Remove textScaleFactor references from flutter/flutter (flutt…
18fa8f8 
…er/flutter#142271)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2024
@engine-flutter-autoroll
505845c Remove textScaleFactor references from flutter/flutter (flutt…
6e24cb1 
…er/flutter#142271)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2024
@engine-flutter-autoroll
505845c Remove textScaleFactor references from flutter/flutter (flutt…
f0d1bbd 
…er/flutter#142271)
@HansMuller HansMuller mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

@TahaTesser TahaTesser Awaiting requested review from TahaTesser

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LongCatIsLooong @albemala @QuncCccccc