Skip to content

Revert "Refactor external_ui → external_textures" #142171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eliasyishak wants to merge 1 commit into from
Closed

Revert "Refactor external_ui → external_textures" #142171

eliasyishak wants to merge 1 commit into from

Conversation

@eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Jan 24, 2024

Reverts #142062

Example of builder erroring out: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20external_ui_integration_test_ios/9562/overview

Sample error

[2024-01-24 13:06:08.688564] [STDOUT] stdout: [  +59 ms] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[2024-01-24 13:06:08.688645] [STDOUT] stdout: [        ] Artifact Instance of 'LegacyCanvasKitRemover' is not required, skipping update.
[2024-01-24 13:06:08.689204] [STDOUT] stdout: [        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[2024-01-24 13:06:08.689265] [STDOUT] stdout: [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[2024-01-24 13:06:08.689301] [STDOUT] stdout: [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[2024-01-24 13:06:08.689334] [STDOUT] stdout: [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[2024-01-24 13:06:08.689403] [STDOUT] stdout: [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[2024-01-24 13:06:08.689442] [STDOUT] stdout: [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[2024-01-24 13:06:08.689475] [STDOUT] stdout: [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[2024-01-24 13:06:08.707419] [STDOUT] stdout: [  +17 ms] "flutter drive" took 20,989ms.
[2024-01-24 13:06:08.713860] [STDOUT] stderr: [   +4 ms] Target file "lib/main.dart" not found.
[2024-01-24 13:06:08.714128] [STDOUT] stderr: [   +1 ms] 
[2024-01-24 13:06:08.714185] [STDOUT] stderr:            #0      FlutterCommand.validateCommand (package:flutter_tools/src/runner/flutter_command.dart:1858:9)
[2024-01-24 13:06:08.714228] [STDOUT] stderr:            #1      DriveCommand.validateCommand (package:flutter_tools/src/commands/drive.dart:227:18)
[2024-01-24 13:06:08.714263] [STDOUT] stderr:            #2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1713:11)
[2024-01-24 13:06:08.714294] [STDOUT] stderr:            <asynchronous suspension>
[2024-01-24 13:06:08.714325] [STDOUT] stderr:            #3      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1398:27)
[2024-01-24 13:06:08.714357] [STDOUT] stderr:            <asynchronous suspension>
[2024-01-24 13:06:08.714459] [STDOUT] stderr:            #4      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
[2024-01-24 13:06:08.714527] [STDOUT] stderr:            <asynchronous suspension>
[2024-01-24 13:06:08.714562] [STDOUT] stderr:            #5      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
[2024-01-24 13:06:08.714594] [STDOUT] stderr:            <asynchronous suspension>
[2024-01-24 13:06:08.714625] [STDOUT] stderr:            #6      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:355:9)
[2024-01-24 13:06:08.714656] [STDOUT] stderr:            <asynchronous suspension>
[2024-01-24 13:06:08.714686] [STDOUT] stderr:            #7      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
[2024-01-24 13:06:08.714717] [STDOUT] stderr:            <asynchronous suspension>
[2024-01-24 13:06:08.714747] [STDOUT] stderr:            #8      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:295:5)
[2024-01-24 13:06:08.714777] [STDOUT] stderr:            <asynchronous suspension>
[2024-01-24 13:06:08.714899] [STDOUT] stderr:            #9      run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:119:9)
[2024-01-24 13:06:08.714943] [STDOUT] stderr:            <asynchronous suspension>
[2024-01-24 13:06:08.714976] [STDOUT] stderr:            #10     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
[2024-01-24 13:06:08.715012] [STDOUT] stderr:            <asynchronous suspension>
[2024-01-24 13:06:08.715043] [STDOUT] stderr:            #11     main (package:flutter_tools/executable.dart:90:3)
[2024-01-24 13:06:08.715100] [STDOUT] stderr:            <asynchronous suspension>
[2024-01-24 13:06:08.715183] [STDOUT] stderr: 
[2024-01-24 13:06:08.715238] [STDOUT] stderr: 
[2024-01-24 13:06:08.715324] [STDOUT] stdout: [        ] ensureAnalyticsSent: 0ms
[2024-01-24 13:06:08.715362] [STDOUT] stdout: [        ] Running 1 shutdown hook
[2024-01-24 13:06:08.715392] [STDOUT] stdout: [        ] Shutdown hooks complete
[2024-01-24 13:06:08.715422] [STDOUT] stdout: [        ] exiting with code 1

@eliasyishak eliasyishak added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 24, 2024
@jonahwilliams
Copy link
Contributor

jonahwilliams commented Jan 24, 2024

Please use the revert label and let CI do the revert.

@eliasyishak
Copy link
Contributor Author

eliasyishak commented Jan 24, 2024

Closing this to use the revert label on the original PR instead

@eliasyishak eliasyishak deleted the revert-142062-external-textures-test branch January 24, 2024 21:39
@matanlurey matanlurey mentioned this pull request Jan 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@johnmccutchan johnmccutchan Awaiting requested review from johnmccutchan

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

No one assigned

Labels

revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliasyishak @jonahwilliams @matanlurey