flutter.groovy: update for Gradle Kotlin DSL compatibility #142144
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
the
tool
bartekpacia
changed the title
final fields also public
|
Note to the potential "test-exemption" giver: this small PR introduces a subset of functionality that already landed in #141541 but then it broke the tree (unknown reasons - see thread). I'd like to land this small PR first, see that nothing breaks in the tree, and then proceed with the rest of changes from #141541. |
|
@reidbaker Could you check what's going on with Google Testing? |
|
overrode the google testing status looks like a back end infra issue |
| File buildGradleKts = new File(path, 'android' + File.separator + 'build.gradle.kts') | ||
| if (buildGradle.exists() && buildGradleKts.exists()) { | ||
| logger.error( | ||
| project.logger.error( |
There was a problem hiding this comment.
this bug existed because code inside this if path is not exercised by any test
| File settingsGradleKts = new File(project.projectDir.parentFile, "settings.gradle.kts") | ||
| if (settingsGradle.exists() && settingsGradleKts.exists()) { | ||
| logger.error( | ||
| project.logger.error( |
There was a problem hiding this comment.
this bug existed because code inside this if path is not exercised by any test
|
Aight, I'm gonna merge this without an exemption. I'm okay if this gets reverted, then I'll double down to get this right haha
|
bartekpacia
added
the
autosubmit
2 participants
This PR fixes 2 small mistakes in
FlutterExtension:publicin order to be used in Gradle Kotlin DSL the same as in Gradle Groovy DSLloggerinstead ofproject.loggerthrows an error when executedThis PR re-adds a subset of changes from #141541 which broke the tree and has been reverted.
Pre-launch Checklist
///).