Run some tests explicitly in both arm and x64. #141910

godofredoc · 2024-01-19T22:56:24Z

This is part of the process to start running tests on either arm64 or x64 if the host architecture is not important for the test.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

.ci.yaml

jmagman · 2024-01-19T23:21:11Z

.ci.yaml

I missed #112033 when I approved #141815. Looks like @vashworth was recently looking at the codesigning issue outside the lab?

Yes, so previously a lot of our chromium arm bots were missing certs (#136651 (comment)), which would cause that test and others to fail so we ran it on devicelab bot. Since upgrading to macOS 13, all Mac-13 chromium bots should have the correct certs now, though. So it should be safe

Comment should be removed

Suggested change

- name: Mac_arm64 module_test_ios # Must be run on devicelab bot for codesigning https://github.com/flutter/flutter/issues/112033

- name: Mac_arm64 module_test_ios

Actually looks like mac_arm64 module_test_ios is failing continuously due to #112033: https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_arm64%20module_test_ios. I think we may need to remove these lines so it codesigns. It's weird to me that it needs to be codesigned for a simulator, but only on chromium bot

Sounds good, I'll send a separate PR for that change.

I think it means in this PR bringup should be removed for Mac_arm64 module_test_ios ? And we we should remove Mac_arm64_ios module_test_ios and lose coverage until the codesigning issue is addressed?

Reverted these tests to its previous state. Would it be possible to get some help landing the fix for the test? that will help me to address a few more PRs to finish updating all the tests.

.ci.yaml

This is part of the process to start running tests on either arm64 or x64 if the host architecture is not important for the test.

.ci.yaml

godofredoc · 2024-01-23T21:26:53Z

@jmagman @vashworth do you have any other comments for this PR?

vashworth

LGTM

flutteractionsbot · 2024-01-24T18:40:02Z

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

christopherfujino · 2024-01-24T19:39:57Z

Failed to create CP due to merge conflicts.You will need to create the PR manually. See the cherrypick wiki for more info.

@XilaiZhang was this an intentional experiment?

XilaiZhang · 2024-01-24T19:44:15Z

Failed to create CP due to merge conflicts.You will need to create the PR manually. See the cherrypick wiki for more info.

@XilaiZhang was this an intentional experiment?

Yeah sorry for the noise, I am testing https://github.com/flutter/flutter/blob/master/.github/workflows/easy-cp.yml at the moment and am trying to find some PRs with a base commit after the merge commit of #142058 to use for testing

christopherfujino · 2024-01-24T22:33:19Z

Failed to create CP due to merge conflicts.You will need to create the PR manually. See the cherrypick wiki for more info.

@XilaiZhang was this an intentional experiment?

Yeah sorry for the noise, I am testing https://github.com/flutter/flutter/blob/master/.github/workflows/easy-cp.yml at the moment and am trying to find some PRs with a base commit after the merge commit of #142058 to use for testing

Sounds good, just wanted to verify there wasn't a bug in the action causing it to run when it shouldn't.

…er#141910)

Roll Flutter from 19b06f4 to a8efa77 (38 revisions) flutter/flutter@19b06f4...a8efa77 2024-01-25 [email protected] Roll Flutter Engine from e2014f007f61 to 7c4ed15cb271 (1 revision) (flutter/flutter#142221) 2024-01-25 [email protected] Roll Flutter Engine from 5fa2e2920274 to e2014f007f61 (1 revision) (flutter/flutter#142213) 2024-01-25 [email protected] provide command to `FakeCommand::onRun` (flutter/flutter#142206) 2024-01-25 [email protected] Roll Flutter Engine from c346fd3d9ca1 to 5fa2e2920274 (1 revision) (flutter/flutter#142212) 2024-01-25 [email protected] Roll Flutter Engine from d4d8f668159b to c346fd3d9ca1 (1 revision) (flutter/flutter#142209) 2024-01-25 [email protected] Roll Flutter Engine from 499ed00bbda2 to d4d8f668159b (2 revisions) (flutter/flutter#142205) 2024-01-25 [email protected] Roll Flutter Engine from 4880592ca5ba to 499ed00bbda2 (6 revisions) (flutter/flutter#142202) 2024-01-25 [email protected] [ci] Adds test for web hot restart with const App. (flutter/flutter#141824) 2024-01-25 [email protected] Migrate android_view to linux_android_emu platform. (flutter/flutter#142184) 2024-01-25 [email protected] Refactor `external_ui` without making any name changes (I think) (flutter/flutter#142192) 2024-01-25 [email protected] Fix text selection edge scrolling when inside a horizontal scrollable (flutter/flutter#140250) 2024-01-25 [email protected] Roll Flutter Engine from d7bf5ec1dcdd to 4880592ca5ba (2 revisions) (flutter/flutter#142186) 2024-01-24 [email protected] Roll Flutter Engine from 6a7f963dc751 to d7bf5ec1dcdd (2 revisions) (flutter/flutter#142185) 2024-01-24 [email protected] Reland "Remove hack from PageView." (flutter/flutter#142172) 2024-01-24 [email protected] Upgrade leak_tracker. (flutter/flutter#142162) 2024-01-24 [email protected] Migrate android views to devicelab. (flutter/flutter#142081) 2024-01-24 [email protected] Roll Flutter Engine from ed498f111d53 to 6a7f963dc751 (4 revisions) (flutter/flutter#142176) 2024-01-24 [email protected] Support wireless debugging for iOS 12 or earlier (flutter/flutter#141439) 2024-01-24 [email protected] Roll Flutter Engine from 4bc368ee5f74 to ed498f111d53 (5 revisions) (flutter/flutter#142167) 2024-01-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Refactor `external_ui` â�� `external_textures`" (flutter/flutter#142173) 2024-01-24 [email protected] Refactor `external_ui` â�� `external_textures` (flutter/flutter#142062) 2024-01-24 [email protected] Roll Flutter Engine from 0b9fce355df9 to 4bc368ee5f74 (3 revisions) (flutter/flutter#142157) 2024-01-24 [email protected] Update navigationBar label's maxScaleFactor to meet GAR requirement (flutter/flutter#141998) 2024-01-24 [email protected] Roll Flutter Engine from b65556fa543e to 0b9fce355df9 (1 revision) (flutter/flutter#142147) 2024-01-24 [email protected] Marks Mac_arm64 build_tests_2_4 to be unflaky (flutter/flutter#142115) 2024-01-24 [email protected] Marks Mac_x64 build_tests_2_4 to be unflaky (flutter/flutter#142111) 2024-01-24 [email protected] Marks Mac_x64 build_tests_1_4 to be unflaky (flutter/flutter#142110) 2024-01-24 [email protected] Marks Mac_x64 build_tests_3_4 to be unflaky (flutter/flutter#142112) 2024-01-24 [email protected] Revise tooltip theme docs, including more cross-references (flutter/flutter#137316) 2024-01-24 [email protected] Run some tests explicitly in both arm and x64. (flutter/flutter#141910) 2024-01-24 [email protected] Roll Flutter Engine from ba3a70ce7722 to b65556fa543e (3 revisions) (flutter/flutter#142140) 2024-01-24 [email protected] Fixes #138773, port autocomplete to OverlayPortal (flutter/flutter#140285) 2024-01-24 [email protected] Revert "[web] - Fix broken `TextField` in semantics mode when it's a sibling of `Navigator`" (flutter/flutter#142129) 2024-01-24 [email protected] Marks Mac_arm64 build_tests_1_4 to be unflaky (flutter/flutter#142114) 2024-01-24 [email protected] Roll Packages from 841fe90 to 8fbdf65 (2 revisions) (flutter/flutter#142139) 2024-01-24 [email protected] Marks Mac_arm64 build_tests_3_4 to be unflaky (flutter/flutter#142116) 2024-01-24 [email protected] Marks Mac_x64 build_tests_4_4 to be unflaky (flutter/flutter#142113) 2024-01-24 [email protected] Marks Mac_arm64 build_tests_4_4 to be unflaky (flutter/flutter#142117) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

@vashworth

As of #147934 `module_test_ios` is passing on non-devicelab machines. Remove the devicelab build and mark the arm non-devicelab build as not flaky. @vashworth's summary from #112033 (comment): > So I believe [the idea](#141910) was to move `Mac_arm64_ios module_test_ios` to `Mac_arm64 module_test_ios` so it doesn't run on a devicelab bot. > > However, it fails when running on a chromium bot due to a `Trying to load an unsigned library` issue, even though it's using a simulator: > https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_arm64%20module_test_ios > > It's unclear why, but it seemed that removing the [lines](#112033 (comment)) that force disabling of codesigning allowed it to run. [@godofredoc was going to do a follow up PR to fix it](#141910 (comment)), but it was probably forgotten. Also remove the x64 version of this test, since there's nothing arch-specific going on here and it happens to be flaky due to an infrastructure issues. Fixes #112033 Fixes #144680

godofredoc requested review from christopherfujino and jmagman January 19, 2024 23:02

jmagman reviewed Jan 19, 2024

View reviewed changes

jmagman reviewed Jan 20, 2024

View reviewed changes

.ci.yaml Outdated Show resolved Hide resolved

godofredoc added 6 commits January 22, 2024 11:51

Run some tests explicitly in both arm and x64.

02e71cf

This is part of the process to start running tests on either arm64 or x64 if the host architecture is not important for the test.

Fix target name.

6421afc

Fix module_test_ios.

5dd73d9

Remove messages related to codesigning.

95313f6

Revert flavors test back to any.

da90985

Revert module_test_ios to its previous state.

02978ed

christopherfujino reviewed Jan 23, 2024

View reviewed changes

.ci.yaml Show resolved Hide resolved

vashworth approved these changes Jan 24, 2024

View reviewed changes

godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2024

auto-submit bot merged commit 5d48b5c into flutter:master Jan 24, 2024

XilaiZhang added the cp: beta cherry pick this pull request to beta release candidate branch label Jan 24, 2024

XilaiZhang removed the cp: beta cherry pick this pull request to beta release candidate branch label Jan 24, 2024

XilaiZhang mentioned this pull request Jan 24, 2024

Track total number of merge conflicts when cherry picking PR from master branch to release branch #141819

Closed

godofredoc deleted the run_both branch January 25, 2024 00:01

engine-flutter-autoroll mentioned this pull request Jan 25, 2024

Roll Flutter from 19b06f4ee9a0 to a8efa771d6a3 (38 revisions) flutter/packages#5969

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 25, 2024

5d48b5c Run some tests explicitly in both arm and x64. (flutter/flutt…

3c717ab

…er#141910)

vashworth mentioned this pull request Jan 26, 2024

Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark errors on hot restart/hot reload #142305

Closed

This was referenced Jan 31, 2024

Marks Mac_arm64_ios integration_test_test_ios to be unflaky #142596

Merged

Marks Mac_x64_ios integration_test_test_ios to be unflaky #142595

Merged

Marks Mac_arm64 tool_tests_commands to be unflaky #142593

Merged

vashworth mentioned this pull request May 13, 2024

module_test_ios failing on M1, 'FlutterUITests' not valid for use in process: Trying to load an unsigned library #112033

Closed

jmagman mentioned this pull request May 13, 2024

Stop running module_test_ios in devicelab and x64 Macs #148264

Merged

	- name: Mac_arm64 module_test_ios # Must be run on devicelab bot for codesigning https://github.com/flutter/flutter/issues/112033
	- name: Mac_arm64 module_test_ios

Run some tests explicitly in both arm and x64. #141910

Run some tests explicitly in both arm and x64. #141910

Uh oh!

Conversation

godofredoc commented Jan 19, 2024

Pre-launch Checklist

Uh oh!

Uh oh!

jmagman Jan 19, 2024

Choose a reason for hiding this comment

Uh oh!

vashworth Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vashworth Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vashworth Jan 22, 2024

Choose a reason for hiding this comment

Uh oh!

godofredoc Jan 22, 2024

Choose a reason for hiding this comment

Uh oh!

jmagman Jan 22, 2024

Choose a reason for hiding this comment

Uh oh!

godofredoc Jan 23, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

godofredoc commented Jan 23, 2024

Uh oh!

vashworth left a comment

Choose a reason for hiding this comment

Uh oh!

flutteractionsbot commented Jan 24, 2024

Uh oh!

christopherfujino commented Jan 24, 2024

Uh oh!

XilaiZhang commented Jan 24, 2024

Uh oh!

christopherfujino commented Jan 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vashworth Jan 19, 2024 •

edited

Loading

vashworth Jan 19, 2024 •

edited

Loading