Skip to content

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jan 19, 2024

This PR changes a golden test.
It is part of an experiment to debug our gold system.

This PR changes a golden test.
It is part of an experiment to debug our gold system.
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jan 19, 2024
@Piinks
Copy link
Contributor

Piinks commented Jan 19, 2024

Let's rebase this after the revert to validate everything works. Waiting on this to land and execute tests in post submit delays fixing the issue.

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #141888 at sha 61d66ca

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 19, 2024
@Hixie Hixie closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants