Update ToggleButtons, ExpansionPanel, and ExpandIcon tests for Material 3
#141868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
TahaTesser
force-pushed
the
update_tests_for_m3
branch
from
9c130bf to
da45f9c
Compare
TahaTesser
force-pushed
the
update_tests_for_m3
branch
from
da45f9c to
0bf11d4
Compare
TahaTesser
force-pushed
the
update_tests_for_m3
branch
from
0bf11d4 to
26a3d06
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
TahaTesser
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 22, 2024
…sts for Material 3 (flutter/flutter#141868)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 22, 2024
…sts for Material 3 (flutter/flutter#141868)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 22, 2024
…sts for Material 3 (flutter/flutter#141868)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 22, 2024
flutter/flutter@5dea6b9...3ee8ff2 2024-01-22 [email protected] Roll Flutter Engine from 40c5e9ce6596 to c49989292fc1 (1 revision) (flutter/flutter#141966) 2024-01-22 [email protected] Roll Packages from 129e08c to e4cbf23 (11 revisions) (flutter/flutter#141962) 2024-01-22 [email protected] Mark defaultTargetPlatform as constant for non-debug non-web builds. (flutter/flutter#141105) 2024-01-22 [email protected] Fix `shape` and `collapsedShape` isn't applied to `ExpansionTile`'s splash ink (flutter/flutter#141777) 2024-01-22 [email protected] Reapply "Native assets: roll deps" (#141748) (flutter/flutter#141864) 2024-01-22 [email protected] Roll Flutter Engine from 11c585f48b77 to 40c5e9ce6596 (1 revision) (flutter/flutter#141956) 2024-01-22 [email protected] Update `ToggleButtons`, `ExpansionPanel`, and `ExpandIcon` tests for Material 3 (flutter/flutter#141868) 2024-01-22 [email protected] Roll Flutter Engine from c485c574fb1d to 11c585f48b77 (1 revision) (flutter/flutter#141952) 2024-01-22 [email protected] Roll Flutter Engine from a7b207d5a1fe to c485c574fb1d (1 revision) (flutter/flutter#141951) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated unit tests for
ToggleButtons,ExpansionPanel, andExpandIconto have M2 and M3 versions.More info in #139076
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.