Reapply "Native assets: roll deps" (#141748) #141864

dcharkes · 2024-01-19T14:52:18Z

Reland: https://dart-review.googlesource.com/c/sdk/+/346960 has rolled into g3, so the imports should now resolve in g3 as well.

Caution

Do NOT merge if "Google Testing" bot didn't run!

Rolls the packages from https://github.com/dart-lang/native in the native assets implementation.

Most notable we're refactoring package:native_assets_cli for build.dart use.
Therefore, all imports to that package for Flutter/Dart should be to the implementation internals that are no longer visible for build.dart writers. Hence all the import updates.

No behavior in Flutter apps should change.

This PR also updates the template to use the latests version of package:native_assets_cli which no longer exposes all the implementation details.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

This reverts commit 1997bec.

dcharkes · 2024-01-19T16:03:47Z

@christopherfujino The "Google Testing" bot again isn't running?

christopherfujino · 2024-01-19T18:09:25Z

@christopherfujino The "Google Testing" bot again isn't running?

I chatted with Casey about this, and it appears to be broken. I am filing a bug now... b/321251334

CaseyHillers · 2024-01-19T18:11:46Z

\cc @Jasguerrero FYI. This is one of the PRs blocked from not having testing.

dcharkes · 2024-01-19T18:19:45Z

Thanks @christopherfujino!

I don't feel very comfortable hitting the submit without testing.

FYI Landing this PR is blocking: https://dart-review.googlesource.com/c/sdk/+/346761 (The cbuild shows that flutter_tools starts failing to build in g3 if we try to land that. Due to the import paths in flutter_tools not yet having changed.) So, I want to make progress on this. Please keep me updated. And if for some reason we can't test the roll with FROB is there a way for me to test it manually?

christopherfujino · 2024-01-19T18:37:07Z

Thanks @christopherfujino!

I don't feel very comfortable hitting the submit without testing.

FYI Landing this PR is blocking: https://dart-review.googlesource.com/c/sdk/+/346761 (The cbuild shows that flutter_tools starts failing to build in g3 if we try to land that. Due to the import paths in flutter_tools not yet having changed.) So, I want to make progress on this. Please keep me updated. And if for some reason we can't test the roll with FROB is there a way for me to test it manually?

My understanding is that getting this unstuck is as simple as manually running a db command (which I believe Casey ran), and that once the CRON runs again it will detect this PR and schedule Google testing. Do I have that right @CaseyHillers?

christopherfujino · 2024-01-19T19:26:26Z

Actually per b/321251334#comment2, it looks like this is still broken and assigned to @Jasguerrero

CaseyHillers · 2024-01-19T19:34:17Z

Following up here, @dcharkes is creating a local version of the change and testing it now. We expect FRoB should recover in the next few hours.

dcharkes · 2024-01-19T19:36:23Z

It looks like FRoB has recovered.

christopherfujino · 2024-01-19T23:23:33Z

packages/flutter_tools/lib/src/update_packages_pins.dart

  'test': '1.24.9', // https://github.com/flutter/flutter/issues/140169
-  'native_assets_builder': '0.3.0', // https://github.com/flutter/flutter/pull/141814
-  'native_assets_cli': '0.3.2', // https://github.com/flutter/flutter/pull/141814
+  'native_assets_builder': '0.3.2', // https://github.com/flutter/flutter/pull/141814


I think we can just remove these pins since you're updating the tool code in this PR.

christopherfujino

LGTM

dcharkes · 2024-01-22T10:41:02Z

[Mon, 22 Jan 2024 10:11:11 UTC] The file changes in this PR do not need to be rolled into google codebase

Well, now that is terrifying! @CaseyHillers our detection of what needs to be tested might be off.

I've run the command locally as well, and I don't see any g3 errors related to flutter_tools, so I think it's safe to land.

…#141864)

flutter/flutter@5dea6b9...3ee8ff2 2024-01-22 [email protected] Roll Flutter Engine from 40c5e9ce6596 to c49989292fc1 (1 revision) (flutter/flutter#141966) 2024-01-22 [email protected] Roll Packages from 129e08c to e4cbf23 (11 revisions) (flutter/flutter#141962) 2024-01-22 [email protected] Mark defaultTargetPlatform as constant for non-debug non-web builds. (flutter/flutter#141105) 2024-01-22 [email protected] Fix `shape` and `collapsedShape` isn't applied to `ExpansionTile`'s splash ink (flutter/flutter#141777) 2024-01-22 [email protected] Reapply "Native assets: roll deps" (#141748) (flutter/flutter#141864) 2024-01-22 [email protected] Roll Flutter Engine from 11c585f48b77 to 40c5e9ce6596 (1 revision) (flutter/flutter#141956) 2024-01-22 [email protected] Update `ToggleButtons`, `ExpansionPanel`, and `ExpandIcon` tests for Material 3 (flutter/flutter#141868) 2024-01-22 [email protected] Roll Flutter Engine from c485c574fb1d to 11c585f48b77 (1 revision) (flutter/flutter#141952) 2024-01-22 [email protected] Roll Flutter Engine from a7b207d5a1fe to c485c574fb1d (1 revision) (flutter/flutter#141951) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reapply "Native assets: roll deps" (#141748)

7827172

This reverts commit 1997bec.

dcharkes requested a review from christopherfujino as a code owner January 19, 2024 14:52

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Jan 19, 2024

dcharkes mentioned this pull request Jan 19, 2024

Consider adding operators to FFI Pointer objects and deprecate/remove not-very-idiomatic elementAt dart-lang/sdk#54250

Closed

Merge branch 'master' into reland-roll-native-packages

d994e9b

christopherfujino mentioned this pull request Jan 19, 2024

rolling native_assets_cli fails #141827

Closed

christopherfujino mentioned this pull request Jan 19, 2024

Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101)" #141814

Merged

Merge branch 'master' into reland-roll-native-packages

eec8293

christopherfujino reviewed Jan 19, 2024

View reviewed changes

dcharkes added 3 commits January 21, 2024 08:39

remove pins

bb26e40

Merge branch 'master' into reland-roll-native-packages

1777162

Merge branch 'master' into reland-roll-native-packages

6cfac81

christopherfujino approved these changes Jan 21, 2024

View reviewed changes

Merge branch 'master' into reland-roll-native-packages

d1d5eb5

dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2024

auto-submit bot merged commit 634b326 into master Jan 22, 2024

auto-submit bot deleted the reland-roll-native-packages branch January 22, 2024 10:42

engine-flutter-autoroll mentioned this pull request Jan 22, 2024

Roll Flutter from 5dea6b994e8f to 7ca4b7b86b9d (7 revisions) flutter/packages#5953

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2024

634b326 Reapply "Native assets: roll deps" (#141748) (flutter/flutter…

7386201

…#141864)

engine-flutter-autoroll mentioned this pull request Jan 22, 2024

Roll Flutter from 5dea6b994e8f to bfa245fa3485 (8 revisions) flutter/packages#5954

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2024

634b326 Reapply "Native assets: roll deps" (#141748) (flutter/flutter…

01f110d

…#141864)

engine-flutter-autoroll mentioned this pull request Jan 22, 2024

Roll Flutter from 5dea6b994e8f to 3ee8ff287a6e (9 revisions) flutter/packages#5955

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2024

634b326 Reapply "Native assets: roll deps" (#141748) (flutter/flutter…

97ec1df

…#141864)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reapply "Native assets: roll deps" (#141748) #141864

Reapply "Native assets: roll deps" (#141748) #141864

Uh oh!

dcharkes commented Jan 19, 2024 •

edited by christopherfujino

Loading

Uh oh!

dcharkes commented Jan 19, 2024

Uh oh!

christopherfujino commented Jan 19, 2024 •

edited

Loading

Uh oh!

CaseyHillers commented Jan 19, 2024 •

edited

Loading

Uh oh!

dcharkes commented Jan 19, 2024 •

edited

Loading

Uh oh!

christopherfujino commented Jan 19, 2024

Uh oh!

christopherfujino commented Jan 19, 2024

Uh oh!

CaseyHillers commented Jan 19, 2024

Uh oh!

dcharkes commented Jan 19, 2024

Uh oh!

christopherfujino Jan 19, 2024

Uh oh!

christopherfujino left a comment

Uh oh!

dcharkes commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Reapply "Native assets: roll deps" (#141748) #141864

Reapply "Native assets: roll deps" (#141748) #141864

Uh oh!

Conversation

dcharkes commented Jan 19, 2024 • edited by christopherfujino Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

dcharkes commented Jan 19, 2024

Uh oh!

christopherfujino commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CaseyHillers commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dcharkes commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christopherfujino commented Jan 19, 2024

Uh oh!

christopherfujino commented Jan 19, 2024

Uh oh!

CaseyHillers commented Jan 19, 2024

Uh oh!

dcharkes commented Jan 19, 2024

Uh oh!

christopherfujino Jan 19, 2024

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

dcharkes commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dcharkes commented Jan 19, 2024 •

edited by christopherfujino

Loading

christopherfujino commented Jan 19, 2024 •

edited

Loading

CaseyHillers commented Jan 19, 2024 •

edited

Loading

dcharkes commented Jan 19, 2024 •

edited

Loading