Skip to content

Conversation

@aizatazhar
Copy link
Contributor

@aizatazhar aizatazhar commented Jan 19, 2024

Reset framesEnabled to true at the end of each test as otherwise subsequent tests may fail when pumping a widget

Fixes #141835

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jan 19, 2024
@aizatazhar aizatazhar force-pushed the frames-enabled branch 2 times, most recently from 4492f16 to 6619afd Compare January 19, 2024 09:40
@aizatazhar aizatazhar marked this pull request as ready for review January 19, 2024 10:51
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2024
@auto-submit auto-submit bot merged commit 75a2e5b into flutter:master Jan 30, 2024
stuartmorgan-g pushed a commit to flutter/packages that referenced this pull request Feb 1, 2024
flutter/flutter@ace9181...75a2e5b

2024-01-30 [email protected] Reset
framesEnabled to default value at the end of each test
(flutter/flutter#141844)
2024-01-30 [email protected] Fix SliverMainAxisGroup geometry
cacheExtent (flutter/flutter#142482)
2024-01-30 [email protected] Roll Flutter Engine from
0e586d1c28c8 to f02a4a80a77e (3 revisions) (flutter/flutter#142528)
2024-01-30 [email protected] Roll Packages from
516648a to 25abb5d (6 revisions) (flutter/flutter#142527)
2024-01-30 [email protected] Roll Flutter Engine from
438e9b4d7d4e to 0e586d1c28c8 (4 revisions) (flutter/flutter#142515)
2024-01-30 [email protected] Using
`initExpensiveAndroidView` for Android Hybrid Composition Mode
(flutter/flutter#142399)
2024-01-30 [email protected] Roll Flutter Engine from
ed73d40a8c93 to 438e9b4d7d4e (1 revision) (flutter/flutter#142508)
2024-01-30 [email protected] Organize leak tracking TODOs.
(flutter/flutter#142460)
2024-01-30 [email protected] Roll Flutter Engine from
5584a78a439b to ed73d40a8c93 (1 revision) (flutter/flutter#142504)
2024-01-30 [email protected] Roll Flutter Engine from
df5f1afd4991 to 5584a78a439b (2 revisions) (flutter/flutter#142503)
2024-01-30 [email protected] Roll Flutter Engine from
65bf8b1db4d1 to df5f1afd4991 (1 revision) (flutter/flutter#142501)
2024-01-30 [email protected] Roll Flutter Engine from
c9268c7db03c to 65bf8b1db4d1 (1 revision) (flutter/flutter#142496)
2024-01-30 [email protected] Roll Flutter Engine from
e21208583956 to c9268c7db03c (1 revision) (flutter/flutter#142492)
2024-01-29 [email protected] Roll Flutter Engine from
bedafa8794b6 to e21208583956 (1 revision) (flutter/flutter#142483)
2024-01-29 [email protected] Revert "Reland:
"Fix how Gradle resolves Android plugin" (#137115)"
(flutter/flutter#142464)
2024-01-29 [email protected] Marks Mac_pixel_7pro
native_assets_android to be unflaky (flutter/flutter#141675)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to
ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SchedulerBinding's framesEnabled state leaks between tests

3 participants