Roll Flutter Engine from d1afda52d254 to 9a6c64de8a46 (2 revisions) #141841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
Jan 19, 2024
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/141841, due to - The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/141841, due to - The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
engine-flutter-autoroll
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/141841, due to - The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Contributor
Author
|
Commit queue failed; closing this roll. |
zanderso
added a commit
that referenced
this pull request
Jan 19, 2024
Includes the Engine roll from #141841 A new version of Dart is having trouble with the tool integration test test `passing one file with errors are detected`: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20tool_integration_tests_2_4/31851/overview. However the analysis server emits the expected errors when we give it both the file without issues and the file with issues. My guess is that the analysis server has changed it's behavior slightly when supplied with a single malformed file. Since the Dart roll is >20 dev versions behind, and this is the only failing presubmit test, and it's testing something a bit weird, I suggest we investigate the right way to test the thing that test was attempting to cover as a follow-up.
engine-flutter-autoroll
deleted the
flutter-engine-flutter-autoroll-e53e529c-177b-436b-b65a-ec6175924d7e-1705643996
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine@d1afda5...9a6c64d
2024-01-19 [email protected] Roll Skia from dd24bd11d79e to e073a4fad57a (1 revision) (flutter/engine#49881)
2024-01-19 [email protected] Manual roll Dart SDK from d6c08fa9bb54 to 8d697eaa395c (23 revisions) (flutter/engine#49880)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md