Skip to content

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jan 18, 2024

Fixes #141743

I should have made this change in #124039, but it escaped my grep search.

@christopherfujino christopherfujino changed the title update analyze_once_test.dart to be null-safe [flutter_tools] update analyze_once_test.dart to be null-safe Jan 18, 2024
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 18, 2024
@zanderso
Copy link
Member

zanderso commented Jan 19, 2024

Combining this with the engine roll to help get the Dart roll unblocked: #141870

Bumping the language version causes missing_return to not be a good target for these tests, so I have to keep it at 2.7 for #141870.

@christopherfujino christopherfujino force-pushed the make-integration-tests-fully-null-safe branch from 1753d25 to ec81c03 Compare January 19, 2024 23:14
@christopherfujino christopherfujino force-pushed the make-integration-tests-fully-null-safe branch from ec81c03 to 629c980 Compare January 19, 2024 23:16
@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 21, 2024
@christopherfujino
Copy link
Contributor Author

FYI @scheglov

@auto-submit auto-submit bot merged commit 9209480 into flutter:master Jan 21, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 21, 2024
flutter/flutter@ddf60fb...5dea6b9

2024-01-21 [email protected] Roll Flutter Engine from 2b31ad2fb819 to a7b207d5a1fe (1 revision) (flutter/flutter#141945)
2024-01-21 [email protected] [flutter_tools] update analyze_once_test.dart to be null-safe (flutter/flutter#141790)
2024-01-21 [email protected] Adjust the position of require File.expand_path (flutter/flutter#141521)
2024-01-21 [email protected] Add RadioListItem use-case to a11y_assessments (flutter/flutter#140984)
2024-01-20 [email protected] Roll Flutter Engine from 704ef3399012 to 2b31ad2fb819 (1 revision) (flutter/flutter#141937)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@christopherfujino christopherfujino deleted the make-integration-tests-fully-null-safe branch January 21, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update packages/flutter_tools/test/integration.shard/analyze_once_test.dart to stop using language 2.7

3 participants