Make test file systems/platforms used in asset_bundle_test.dart less dependent on the host platform #141657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
andrewkolos
force-pushed
the
merge-asset-test-files
branch
from
3304072 to
0d2a5f1
Compare
andrewkolos
changed the title
Contributor
Author
|
@christopherfujino Let me know if this is sufficient in addressing your comment on #141214. If we want to make these tests truly hermetic, |
andrewkolos
added
the
autosubmit
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 18, 2024
…rt less dependent on the host platform (flutter/flutter#141657)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 18, 2024
flutter/flutter@def6af0...f77f824 2024-01-18 [email protected] Roll Flutter Engine from 49fa2cb9024f to b75d6d80d813 (1 revision) (flutter/flutter#141771) 2024-01-18 [email protected] Roll Flutter Engine from 49c6ca211aa4 to 49fa2cb9024f (1 revision) (flutter/flutter#141762) 2024-01-18 [email protected] Roll Flutter Engine from 873449c27d5a to 49c6ca211aa4 (1 revision) (flutter/flutter#141760) 2024-01-18 [email protected] Roll Flutter Engine from bfdc0c5b2826 to 873449c27d5a (1 revision) (flutter/flutter#141759) 2024-01-18 [email protected] Catch UnsupportedError thrown when user provides an asset directory path containing invalid characters (flutter/flutter#141214) 2024-01-18 [email protected] Roll Flutter Engine from 48f89ac064ac to bfdc0c5b2826 (1 revision) (flutter/flutter#141752) 2024-01-18 [email protected] Roll Flutter Engine from 924c17245a78 to 48f89ac064ac (2 revisions) (flutter/flutter#141751) 2024-01-18 [email protected] Roll Flutter Engine from 98c16b430e6b to 924c17245a78 (1 revision) (flutter/flutter#141749) 2024-01-18 [email protected] Roll Flutter Engine from 73a2de5da53f to 98c16b430e6b (16 revisions) (flutter/flutter#141744) 2024-01-18 [email protected] Move mac pixel 7 pro test to presubmit: false (flutter/flutter#141747) 2024-01-18 [email protected] [web] prepare layers_test.dart for flutter/engine#49786 (flutter/flutter#141731) 2024-01-17 [email protected] Remove non-needed bot and increase time out for leak_tracking. (flutter/flutter#141712) 2024-01-17 [email protected] Add `headerHeight` for `SearchAnchor` (flutter/flutter#141223) 2024-01-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/flutter#141715) 2024-01-17 [email protected] Make test file systems/platforms used in asset_bundle_test.dart less dependent on the host platform (flutter/flutter#141657) 2024-01-17 [email protected] Native assets: roll deps (flutter/flutter#141684) 2024-01-17 [email protected] Run build tests on both x64 and arm64. (flutter/flutter#141206) 2024-01-17 [email protected] Update tests to Xcode 15 (flutter/flutter#141706) 2024-01-17 [email protected] [web] prepare for flutter/engine#49786 (flutter/flutter#141700) 2024-01-17 [email protected] Marks Windows framework_tests_misc_leak_tracking to be unflaky (flutter/flutter#141676) 2024-01-17 [email protected] Label "flutter_localizations" PRs with "framework" (flutter/flutter#141654) 2024-01-17 [email protected] Fix Tooltip show delay when mouse moves to one Tooltip from another (flutter/flutter#141656) 2024-01-17 [email protected] Roll Packages from 7dd0fcb to 1a2b780 (6 revisions) (flutter/flutter#141683) 2024-01-17 [email protected] Fix the --empty flag to not try working with non-app templates (flutter/flutter#141632) 2024-01-17 [email protected] Revert "Roll Flutter Engine from 73a2de5da53f to c7e328518bc0 (5 revisions)" (flutter/flutter#141691) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of work on #141214. See this discussion for the inspiration for this PR.
Issue
Many tests in packages/flutter_tools/test/general.shard/asset_bundle_test.dart aren't hermetic. When setting up fake
FileSystemandPlatformobjects, the host OS is referenced:flutter/packages/flutter_tools/test/general.shard/asset_bundle_test.dart
Lines 35 to 40 in f2745e9
flutter/packages/flutter_tools/test/general.shard/asset_bundle_test.dart
Line 43 in f2745e9
To improve hermeticity here, we could instead run each once per valid combination of file system style and platform. However, it is unclear if these tests even depend on the file system style (integration tests should catch most cases where this might matter). As a result, I think it's sufficient to improve hermeticity by always assuming a Linux environment, which is generally our default (as
MemoryFileSystemdoes, and most of our fakes ofPlatformdo by default).In general, if a test needs to run other kinds of environments, it should make this clear, ideally through the test name.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.