Reverts "BoxPainter should dispatch creation and disposal events." #141545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
github-actions
bot
added
the
framework
fluttergithubbot
approved these changes
Jan 15, 2024
auto-submit
bot
deleted the
revert_1a2c3151fef25e88cfde49110f40a2c3d76cb114
branch
8 tasks
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 16, 2024
flutter/flutter@1a2c315...8e94423 2024-01-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "BoxPainter should dispatch creation and disposal events." (flutter/flutter#141545) 2024-01-14 [email protected] Private disposables should dispatch creation and disposal events. (flutter/flutter#141535) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #141526
Initiated by: CaseyHillers
This change reverts the following previous change:
Original Description:
Description
BoxPaintercreation and disposal events dispatching for memory leak tracking as part of Clean up 'not disposed' memory leaks in FF, phase 3. #141198Tests
decoration_test.dartto testBoxPainterobject creation and disposal events dispatching.Pre-launch Checklist
///).