Private disposables should dispatch creation and disposal events. #141535
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
framework
|
cc @polina-c |
Tests are added to memory allocations testing. |
|
@polina-c thanks for the review! |
|
@polina-c please do not land PRs that do not have test exemptions, see https://github.com/flutter/flutter/wiki/Tree-hygiene#tests |
@Hixie , I thought this PR does not need test exemption any more since the tests were updated in this PR after auto alert was generated: #141535 (comment) Am i wrong? |
|
Oh, so they were, my apologies. |
polina-c
added
the
a: leak tracking
flutter/flutter@1a2c315...8e94423 2024-01-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "BoxPainter should dispatch creation and disposal events." (flutter/flutter#141545) 2024-01-14 [email protected] Private disposables should dispatch creation and disposal events. (flutter/flutter#141535) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This PR contributes to #141198
Description
_HeroFlightleak inHeroController_AnimationTuplecreation and disposal events dispatching for memory leak tracking_IndicatorPaintercreation and disposal events dispatching for memory leak tracking_DialPaintercreation and disposal events dispatching for memory leak tracking_DecorationImagePaintercreation and disposal events dispatching for memory leak tracking_BlendedDecorationImagePaintercreation and disposal events dispatching for memory leak tracking_CachedImageBasecreation and disposal events dispatching for memory leak tracking_BindingPipelineManifoldcreation and disposal events dispatching for memory leak tracking_DraggableSheetExtentcreation and disposal events dispatching for memory leak tracking_HighlightModeManagercreation and disposal events dispatching for memory leak tracking_HeroFlightcreation and disposal events dispatching for memory leak tracking_NestedScrollCoordinatorcreation and disposal events dispatching for memory leak tracking_GlowControllercreation and disposal events dispatching for memory leak tracking_StretchControllercreation and disposal events dispatching for memory leak tracking_DragInfocreation and disposal events dispatching for memory leak tracking_SemanticsClientcreation and disposal events dispatching for memory leak tracking_ScreenshotDatacreation and disposal events dispatching for memory leak trackingPre-launch Checklist
///).